Skip to content

[Chip] Add color prop to chip component #12378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 2, 2018
Merged

[Chip] Add color prop to chip component #12378

merged 4 commits into from
Aug 2, 2018

Conversation

@itelo
Copy link
Contributor

@itelo itelo commented Aug 2, 2018 •
edited by oliviertassinari
Loading

Closes #12370

@itelo
Copy link
Contributor Author

itelo commented Aug 2, 2018

add a ChipPlayground
image

add color primary and secondary
image
image

@oliviertassinari oliviertassinari changed the title [Chip]: add color prop to chip component [Chip] Add color prop to chip component Aug 2, 2018
@oliviertassinari oliviertassinari added type: new feature Expand the scope of the product to solve a new problem. scope: chip Changes related to the chip. labels Aug 2, 2018
@oliviertassinari oliviertassinari force-pushed the master branch 3 times, most recently from ca31616 to ccc2dbf Compare August 2, 2018 21:08
@oliviertassinari oliviertassinari merged commit 5c7b379 into mui:master Aug 2, 2018
@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 2, 2018

@itelo Great job!

@mbrookes
Copy link
Member

mbrookes commented Aug 3, 2018

Sweet!

@IvanCoronado
Copy link
Contributor

IvanCoronado commented Aug 22, 2018

@itelo You have missed the colorPrimary and colorSecondary class for TS https://github.com/mui-org/material-ui/blob/master/packages/material-ui/src/Chip/Chip.d.ts#L16-L31

@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 22, 2018

@IvanCoronado Do you want to submit a pull request to add them?

@IvanCoronado
Copy link
Contributor

IvanCoronado commented Aug 22, 2018

@oliviertassinari Done #12625 👍

@snyk-bot snyk-bot mentioned this pull request Sep 30, 2019
Open
@shasu01
Copy link

shasu01 commented Mar 10, 2020

How would you remove the color in js, because its not found when you search hasAttribute

This was referenced Mar 26, 2020
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

scope: chip Changes related to the chip. type: new feature Expand the scope of the product to solve a new problem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Chip missing color prop

5 participants

@itelo @oliviertassinari @mbrookes @IvanCoronado @shasu01