Skip to content

Conversation

@xkenmon
Copy link
Contributor

@xkenmon xkenmon commented Jul 31, 2018

In some cases(some elements of the same orderBy), the order of elements changes when multiple choices.

@oliviertassinari
Copy link
Member

@xkenmon Do you mean we miss the if a equal b then return 0 test case?

@xkenmon
Copy link
Contributor Author

xkenmon commented Jul 31, 2018

@oliviertassinari Yes,not returning 0 caused sorting confusion in multiple selections

@oliviertassinari oliviertassinari changed the title Update EnhancedTable.js [docs] Improve the sorting logic Jul 31, 2018
@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation. scope: table Changes related to the table. labels Jul 31, 2018
@oliviertassinari oliviertassinari changed the title [docs] Improve the sorting logic [docs] Improve the Table sorting logic Jul 31, 2018
@oliviertassinari oliviertassinari merged commit fde400f into mui:master Jul 31, 2018
@oliviertassinari
Copy link
Member

@xkenmon Thank you for raising the concern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation. scope: table Changes related to the table.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants