Skip to content

Conversation

@sakulstra
Copy link
Contributor

@sakulstra sakulstra commented Jul 22, 2018

wanted to use required, so i forwarded all props suggested in ticket.

Closes #12179


not sure where to add the docs

@sakulstra sakulstra changed the title forward required, readonly and autofocus to switchBase [SwitchBase] forward required, readonly and autofocus to switchBase Jul 22, 2018
@oliviertassinari oliviertassinari self-assigned this Jul 22, 2018
@oliviertassinari oliviertassinari added the type: new feature Expand the scope of the product to solve a new problem. label Jul 22, 2018
@oliviertassinari oliviertassinari changed the title [SwitchBase] forward required, readonly and autofocus to switchBase [input] Forward required, readOnly and autoFocus Jul 22, 2018
@oliviertassinari
Copy link
Member

@sakulstra Thanks! I'm going one step further by adding the required support to the Input component.

@oliviertassinari oliviertassinari merged commit 18aa629 into mui:master Jul 22, 2018
@mnemanja
Copy link
Contributor

@sakulstra & @oliviertassinari ,

I'm on the version 1.4.1 but not able to pass the readOnly attribute through the TextField component nor the InputProps on the TextField component.

screen shot 2018-07-26 at 10 58 43

And when I've searched for the definition, neither of the two definitions, TextField.d.ts nor Input.d.ts have any mention of the readOnly property.

screen shot 2018-07-26 at 10 56 51

screen shot 2018-07-26 at 10 56 21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: new feature Expand the scope of the product to solve a new problem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants