[Dialog] Fix action width issue #12081
Conversation
|
This is my first contribution to MU project and I couldn't run the tests ( it was complaining about missing packages and stuff! I read the documentation for Contribution, Code of conduct and testing instructions but with multiple Thanks! :) |
|
@oliviertassinari Do we need to update the Argos snapshots for this or should it have gone through without any changes to the UI? |
| lineHeight: '1.4em', // Improve readability for multiline button. | ||
| boxSizing: 'border-box', | ||
| minWidth: 88, | ||
| minWidth: theme.spacing.unit * 8, |
There was a problem hiding this comment.
We've moved away from using theme.spacing.unit in components, but setting this to 64 would be a breaking change IMHO.
There was a problem hiding this comment.
Yeah, I think you are right, as theme.spacing.unit * 8 is being calculated to 64 already and that changes the rendering in a few component ( not sure if that's not expected )
I've changed it for now tho if we are not using theme.spacing.unit anymore.
oliviertassinari
changed the title
oliviertassinari
added
type: bug
…re incorrect when rendered in a Dialog )
….spacing.unit * 8
oliviertassinari
force-pushed
the
issue_11837
branch
from
f230e7b to
0344b94
Compare
|
@mbrookes MCW is using 64px too. I think that this change is part of their new strategy, makes Material Design less opinionated.
|
|
@mim-Armand It's a great first pull request on Material-UI 👌🏻. Thank you for giving it a shot! |
mbrookes
added
the
breaking change
* attemting to fix Issue mui#11837 ( where the CircularProgress size were incorrect when rendered in a Dialog ) * changint the max-with to the calculated amount instead of using theme.spacing.unit * 8 * remove dialog action min-width
4 participants
Closes #11837
Thank you for your feedback.