Skip to content

Conversation

@mbrookes
Copy link
Member

@mbrookes mbrookes commented Jun 21, 2018

image

Closes #11932

@oliviertassinari
Copy link
Member

Maybe fab-extended? Why do we need this variation?

@mbrookes
Copy link
Member Author

Why do we need this variation?

Ask Google! 😄

https://material.io/design/components/buttons-floating-action-button.html#extended-fab

boxShadow: theme.shadows[12],
},
},
extended: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is off:

  • property name: extended-fab
  • class name: extended

Maybe using extendedFab? for the variant name?

@oliviertassinari oliviertassinari added scope: button Changes related to the button. design: material This is about Material Design, please involve a visual or UX designer in the process labels Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

design: material This is about Material Design, please involve a visual or UX designer in the process scope: button Changes related to the button.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants