Skip to content

LightProbeGenerator: Add support for half float render targets. #26773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2023
Merged

LightProbeGenerator: Add support for half float render targets. #26773

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 37 additions & 3 deletions examples/jsm/lights/LightProbeGenerator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@ import {
SphericalHarmonics3,
Vector3,
SRGBColorSpace,
NoColorSpace
NoColorSpace,
HalfFloatType,
DataUtils
} from 'three';

class LightProbeGenerator {
Expand Down Expand Up @@ -140,18 +142,50 @@ class LightProbeGenerator {
const sh = new SphericalHarmonics3();
const shCoefficients = sh.coefficients;

const dataType = cubeRenderTarget.texture.type;

for ( let faceIndex = 0; faceIndex < 6; faceIndex ++ ) {

const imageWidth = cubeRenderTarget.width; // assumed to be square
const data = new Uint8Array( imageWidth * imageWidth * 4 );

let data;

if ( dataType === HalfFloatType ) {

data = new Uint16Array( imageWidth * imageWidth * 4 );

} else {

// assuming UnsignedByteType

data = new Uint8Array( imageWidth * imageWidth * 4 );

}

renderer.readRenderTargetPixels( cubeRenderTarget, 0, 0, imageWidth, imageWidth, data, faceIndex );

const pixelSize = 2 / imageWidth;

for ( let i = 0, il = data.length; i < il; i += 4 ) { // RGBA assumed

let r, g, b;

if ( dataType === HalfFloatType ) {

r = DataUtils.fromHalfFloat( data[ i ] );
g = DataUtils.fromHalfFloat( data[ i + 1 ] );
b = DataUtils.fromHalfFloat( data[ i + 2 ] );

} else {

r = data[ i ] / 255;
g = data[ i + 1 ] / 255;
b = data[ i + 2 ] / 255;

}

// pixel color
color.setRGB( data[ i ] / 255, data[ i + 1 ] / 255, data[ i + 2 ] / 255 );
color.setRGB( r, g, b );

// convert to linear color space
convertColorToLinear( color, cubeRenderTarget.texture.colorSpace );
Expand Down