Skip to content

AnimationUtils: Remove arraySlice(). #26756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 21, 2023
Merged

AnimationUtils: Remove arraySlice(). #26756

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ab265ee
use default
ycw Sep 14, 2023
e49bda6
exclusive
ycw Sep 14, 2023
c51aae0
rm arraySlice
ycw Sep 19, 2023
5bc34d6
rm test, rm docs
ycw Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/animation/AnimationUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@ import { Quaternion } from '../math/Quaternion.js';
import { AdditiveAnimationBlendMode } from '../constants.js';

// same as Array.prototype.slice, but also works on typed arrays
function arraySlice( array, from, to ) {
function arraySlice( array, from, to = array.length ) {

if ( isTypedArray( array ) ) {

// in ios9 array.subarray(from, undefined) will return empty array
// but array.subarray(from) or array.subarray(from, len) is correct
return new array.constructor( array.subarray( from, to !== undefined ? to : array.length ) );
return new array.constructor( array.subarray( from, to ) );

}

Expand Down