Remove hack now that atlassian-api/atlassian-python-api#1378 was fixed

Author: leplatrem

jbi/jira/client.py

@@ -1,4 +1,3 @@
-import json
 import logging
 from typing import Collection, Iterable, Optional
 
@@ -64,18 +63,9 @@ def raise_for_status(self, *args, **kwargs):
                 response.reason,
                 extra={"body": response.text},
             )
-            if str(exc) == "":
-                # Some Jira errors are raised as `HTTPError('')`.
-                # We are trying to turn them into insightful errors here.
-                try:
-                    content = exc.response.json()
-                    errors = content.get("errors", {})
-                    response_details = ",".join(f"{k}: {v}" for k, v in errors.items())
-                except json.JSONDecodeError:
-                    response_details = exc.response.text
-                # Set the exception message so that its str version contains details.
-                msg = f"HTTP {exc.response.status_code}: {response_details}"
-                exc.args = (msg,) + exc.args[1:]
+            # Set the exception message so that its str version contains details.
+            msg = f"HTTP {exc.response.status_code}: {exc}"
+            exc.args = (msg,) + exc.args[1:]
             raise
 
     get_server_info = instrumented_method(Jira.get_server_info)

tests/unit/test_runner.py

@@ -375,10 +375,7 @@ async def test_execute_or_queue_http_error_details(
 
     items = (await dl_queue.retrieve())[bug.id]
     [item] = [i async for i in items]
-    assert (
-        item.error.description
-        == "HTTP 400: resolution: Field 'resolution' cannot be set."
-    )
+    assert item.error.description == "HTTP 400: Field 'resolution' cannot be set."
 
 
 def test_default_invalid_init():