Skip to content

Commit 6a44c59

Browse files
committed
Update ChangeLog
- TODO: Reuse TCP connections - Update "Parse Content-Type" bullet
1 parent e9cd78d commit 6a44c59

File tree

2 files changed

+19
-2
lines changed

2 files changed

+19
-2
lines changed

ChangeLog.md

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,21 @@ Upcoming
2323
Unscheduled
2424
-----------
2525

26+
* Support reusing TCP connections, and "pipelining" of requests, a la
27+
RFC 2068, Sect 8.1, L2377
28+
29+
- The user must ask for pipelining, and supply a callback function
30+
to be called after a response is received.
31+
- Rename Client.request() -> Client.addRequest() (or such)
32+
- Have Client.addRequest() check whether a persistent connection is
33+
wanted, and save the entire request in a Client.pendingRequests
34+
list in that case
35+
- Create a new Client.sendRequests() method which the user may call
36+
to send all requests up the pipeline. (It should work even if the
37+
server does not support pipelining)
38+
- Call the user-supplied callback whenever a request is received.
39+
There are some concurrency issues here, and we may elect to call
40+
the callback only after *all* requests are received.
2641

2742
* Create a script to pack the basic module and any given set of
2843
service-specific classes as one file
@@ -89,8 +104,9 @@ v2.0
89104
- Does GitHub support this? It should. And if so, we should use it
90105
by default
91106

92-
* Parse Content-Type header more correctly; make a dict of the
93-
parameters available to the media-type handlers
107+
* Parse Content-Type header correctly; make a dict of the
108+
parameters (Content.ctypeParameters) available to the media-type
109+
handlers
94110

95111
v1.1.1
96112
------

agithub.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -232,6 +232,7 @@ def request(self, method, url, body, headers):
232232
if self.username:
233233
headers['authorization'] = self.authHeader
234234

235+
235236
reqBody = RequestBody(body, headers)
236237
conn = self.getConnection()
237238
conn.request(method, url, reqBody.process(), headers)

0 commit comments

Comments
 (0)