Skip to content

feat(NODE-5430)!: make AutoEncrypter and MongoClient.autoEncrypter internal #3789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2023
Merged

feat(NODE-5430)!: make AutoEncrypter and MongoClient.autoEncrypter internal #3789

merged 1 commit into from
Jul 31, 2023

Conversation

@W-A-James
Copy link
Contributor

@W-A-James W-A-James commented Jul 31, 2023 •
edited by nbbeeken
Loading

Description

What is changing?

Is there new documentation needed for these changes?

What is the motivation for this change?

Release Highlight

AutoEncrypter and MongoClient.autoEncrypter are now internal

As of this release, users will no longer be able to access the AutoEncrypter interface or the MongoClient.autoEncrypter field of an encrypted MongoClient instance.

This was done as part of our migration of mongodb-client-encryption to the driver codebase. See #3770 for more.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@W-A-James W-A-James changed the title feat!(NODE-5430): make AutoEncrypter and MongoClient.autoEncrypter pr… feat!(NODE-5430): make AutoEncrypter and MongoClient.autoEncrypter internal Jul 31, 2023
@W-A-James W-A-James marked this pull request as ready for review July 31, 2023 19:15
@nbbeeken nbbeeken changed the title feat!(NODE-5430): make AutoEncrypter and MongoClient.autoEncrypter internal feat(NODE-5430)!: make AutoEncrypter and MongoClient.autoEncrypter internal Jul 31, 2023
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jul 31, 2023
@nbbeeken nbbeeken self-assigned this Jul 31, 2023
@nbbeeken nbbeeken self-requested a review July 31, 2023 20:43
@nbbeeken nbbeeken merged commit b16ef9e into main Jul 31, 2023
@nbbeeken nbbeeken deleted the NODE-5430 branch July 31, 2023 20:43
@github-actions github-actions bot mentioned this pull request Jul 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nbbeeken nbbeeken Awaiting requested review from nbbeeken

Assignees

@nbbeeken nbbeeken

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@W-A-James @nbbeeken