fix(NODE-4583): revert nested union type support #3383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Failures on latest: https://jira.mongodb.org/browse/SERVER-69146 |
durran
added
the
Primary Review
dariakp
approved these changes
Aug 25, 2022
dariakp
added
Team Review
dariakp
changed the title
nbbeeken
approved these changes
Aug 25, 2022
durran
added a commit
that referenced
this pull request
Aug 30, 2022
durran
added a commit
that referenced
this pull request
Aug 30, 2022
durran
added a commit
that referenced
this pull request
Aug 31, 2022
baileympearson
pushed a commit
that referenced
this pull request
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reverts the strict nested union types support.
What is changing?
Reverts #3349 and comments out the added test with link to original ticket.
Reopens NODE-4513
Is there new documentation needed for these changes?
None
What is the motivation for this change?
NODE-4583 / NODE-4571
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>