Skip to content

fix(NODE-3430): watch method types on MongoClient and Db #2900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2021
Merged

fix(NODE-3430): watch method types on MongoClient and Db #2900

merged 1 commit into from
Jul 13, 2021

Conversation

@nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Jul 13, 2021

Remove overrides, types fix

@nbbeeken nbbeeken requested review from dariakp and emadum July 13, 2021 16:00
@nbbeeken nbbeeken changed the title NODE-3430/watch-overrride fix(NODE-3430): watch method types on MongoClient and Db Jul 13, 2021
dariakp
dariakp approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dariakp dariakp merged commit 17cc291 into 4.0 Jul 13, 2021
@dariakp dariakp deleted the NODE-3430/watch-overrride branch July 13, 2021 17:19
ljhaywar pushed a commit that referenced this pull request Nov 9, 2021
@nbbeeken @ljhaywar
fix(NODE-3430): watch method types on MongoClient and Db (#2900)
62aa290
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dariakp dariakp dariakp approved these changes

+1 more reviewer

@emadum emadum emadum approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nbbeeken @emadum @dariakp