test(NODE-5370): add e2e testing for the search index management API (#3736)

Co-authored-by: Durran Jordan <[email protected]>

Author: baileympearson

.evergreen/config.in.yml

@@ -45,15 +45,6 @@ functions:
       params:
         file: src/expansion.yml
 
-  "run search index management tests":
-    - command: subprocess.exec
-      params:
-        binary: bash
-        working_dir: src
-        add_expansions_to_env: true
-        args:
-          - .evergreen/run-search-index-management-tests.sh
-
   "bootstrap mongo-orchestration":
     - command: subprocess.exec
       params:
@@ -1281,6 +1272,19 @@ tasks:
             TEST_LAMBDA_DIRECTORY: ${PROJECT_DIRECTORY}/test/lambda
             AWS_REGION: us-east-1
 
+  - name: test-search-index-helpers
+    commands:
+      - func: install dependencies
+        vars:
+          NODE_LTS_VERSION: 20
+      - command: subprocess.exec
+        params:
+          working_dir: src
+          binary: bash
+          add_expansions_to_env: true
+          args:
+            - .evergreen/run-search-index-management-tests.sh
+
 task_groups:
   - name: serverless_task_group
     setup_group_can_fail_task: true
@@ -1420,6 +1424,8 @@ task_groups:
           working_dir: src
           binary: bash
           add_expansions_to_env: true
+          env:
+            MONGODB_VERSION: "7.0"
           args:
             - ${DRIVERS_TOOLS}/.evergreen/atlas/setup-atlas-cluster.sh
       - command: expansions.update
@@ -1438,6 +1444,34 @@ task_groups:
     tasks:
       - test-aws-lambda-deployed
 
+  - name: test_atlas_task_group_search_indexes
+    setup_group:
+      - func: fetch source
+      - command: subprocess.exec
+        params:
+          working_dir: src
+          binary: bash
+          add_expansions_to_env: true
+          env:
+            MONGODB_VERSION: "7.0"
+          args:
+            - ${DRIVERS_TOOLS}/.evergreen/atlas/setup-atlas-cluster.sh
+      - command: expansions.update
+        params:
+          file: src/atlas-expansion.yml
+    teardown_group:
+      - command: subprocess.exec
+        params:
+          working_dir: src
+          binary: bash
+          add_expansions_to_env: true
+          args:
+            - ${DRIVERS_TOOLS}/.evergreen/atlas/teardown-atlas-cluster.sh
+    setup_group_can_fail_task: true
+    setup_group_timeout_secs: 1800
+    tasks:
+      - test-search-index-helpers
+
 pre:
   - func: "fetch source"
   - func: "windows fix"

.evergreen/config.yml

@@ -25,14 +25,6 @@ functions:
     - command: expansions.update
       params:
         file: src/expansion.yml
-  run search index management tests:
-    - command: subprocess.exec
-      params:
-        binary: bash
-        working_dir: src
-        add_expansions_to_env: true
-        args:
-          - .evergreen/run-search-index-management-tests.sh
   bootstrap mongo-orchestration:
     - command: subprocess.exec
       params:
@@ -1204,6 +1196,18 @@ tasks:
           env:
             TEST_LAMBDA_DIRECTORY: ${PROJECT_DIRECTORY}/test/lambda
             AWS_REGION: us-east-1
+  - name: test-search-index-helpers
+    commands:
+      - func: install dependencies
+        vars:
+          NODE_LTS_VERSION: 20
+      - command: subprocess.exec
+        params:
+          working_dir: src
+          binary: bash
+          add_expansions_to_env: true
+          args:
+            - .evergreen/run-search-index-management-tests.sh
   - name: test-latest-server
     tags:
       - latest
@@ -2651,17 +2655,6 @@ tasks:
         variant: '*'
         status: '*'
         patch_optional: true
-  - name: test-search-index-helpers
-    tags: []
-    commands:
-      - func: install dependencies
-        vars:
-          NODE_LTS_NAME: 20
-      - func: bootstrap mongo-orchestration
-        vars:
-          VERSION: latest
-          TOPOLOGY: replica_set
-      - func: run search index management tests
   - name: run-custom-csfle-tests-5.0-pinned-commit
     tags:
       - run-custom-dependency-tests
@@ -3473,6 +3466,8 @@ task_groups:
           working_dir: src
           binary: bash
           add_expansions_to_env: true
+          env:
+            MONGODB_VERSION: '7.0'
           args:
             - ${DRIVERS_TOOLS}/.evergreen/atlas/setup-atlas-cluster.sh
       - command: expansions.update
@@ -3490,6 +3485,33 @@ task_groups:
     setup_group_timeout_secs: 1800
     tasks:
       - test-aws-lambda-deployed
+  - name: test_atlas_task_group_search_indexes
+    setup_group:
+      - func: fetch source
+      - command: subprocess.exec
+        params:
+          working_dir: src
+          binary: bash
+          add_expansions_to_env: true
+          env:
+            MONGODB_VERSION: '7.0'
+          args:
+            - ${DRIVERS_TOOLS}/.evergreen/atlas/setup-atlas-cluster.sh
+      - command: expansions.update
+        params:
+          file: src/atlas-expansion.yml
+    teardown_group:
+      - command: subprocess.exec
+        params:
+          working_dir: src
+          binary: bash
+          add_expansions_to_env: true
+          args:
+            - ${DRIVERS_TOOLS}/.evergreen/atlas/teardown-atlas-cluster.sh
+    setup_group_can_fail_task: true
+    setup_group_timeout_secs: 1800
+    tasks:
+      - test-search-index-helpers
 pre:
   - func: fetch source
   - func: windows fix
@@ -4063,8 +4085,8 @@ buildvariants:
     tasks:
       - test-lambda-example
       - test-lambda-aws-auth-example
-  - name: rhel8-test-seach-index-management-helpers
-    display_name: Search Index Management Helpers Tests
+  - name: rhel8-test-search-indexes
+    display_name: Search Index Tests
     run_on: rhel80-large
     tasks:
-      - test-search-index-helpers
+      - test_atlas_task_group_search_indexes

.evergreen/generate_evergreen_tasks.js

@@ -547,6 +547,7 @@ SINGLETON_TASKS.push(
   ]
 );
 
+
 function* makeTypescriptTasks() {
   for (const TS_VERSION of ['next', 'current', '4.1.6']) {
     // 4.1.6 can consume the public API but not compile the driver
@@ -688,26 +689,6 @@ const coverageTask = {
 };
 
 SINGLETON_TASKS.push(coverageTask);
-SINGLETON_TASKS.push({
-  name: 'test-search-index-helpers',
-  tags: [],
-  commands: [
-    {
-      func: 'install dependencies',
-      vars: {
-        NODE_LTS_NAME: LATEST_LTS
-      }
-    },
-    {
-      func: 'bootstrap mongo-orchestration',
-      vars: {
-        VERSION: 'latest',
-        TOPOLOGY: 'replica_set'
-      }
-    },
-    { func: 'run search index management tests' }
-  ]
-})
 SINGLETON_TASKS.push(...oneOffFuncAsTasks);
 
 BUILD_VARIANTS.push({
@@ -776,11 +757,11 @@ BUILD_VARIANTS.push({
 });
 
 BUILD_VARIANTS.push({
-  name: 'rhel8-test-seach-index-management-helpers',
-  display_name: 'Search Index Management Helpers Tests',
+  name: 'rhel8-test-search-indexes',
+  display_name: 'Search Index Tests',
   run_on: DEFAULT_OS,
-  tasks: ['test-search-index-helpers']
-})
+  tasks: ['test_atlas_task_group_search_indexes']
+});
 
 // TODO(NODE-4575): unskip zstd and snappy on node 16
 for (const variant of BUILD_VARIANTS.filter(

.evergreen/run-search-index-management-tests.sh

@@ -1,5 +1,5 @@
 #! /bin/bash
 
-source "${PROJECT_DIRECTORY}/.evergreen/init-nvm.sh"
+source "${PROJECT_DIRECTORY}/.evergreen/init-node-and-npm-env.sh"
 
 npm run check:search-indexes

package.json

@@ -140,7 +140,7 @@
     "check:tsd": "tsd --version && tsd",
     "check:dependencies": "mocha test/action/dependency.test.ts",
     "check:dts": "node ./node_modules/typescript/bin/tsc --noEmit mongodb.d.ts && tsd",
-    "check:search-indexes": "nyc mocha --config test/mocha_mongodb.json test/manual/search-index-management.spec.test.ts",
+    "check:search-indexes": "nyc mocha --config test/mocha_mongodb.json test/manual/search-index-management.prose.test.ts",
     "check:test": "mocha --config test/mocha_mongodb.json test/integration",
     "check:unit": "mocha test/unit",
     "check:ts": "node ./node_modules/typescript/bin/tsc -v && node ./node_modules/typescript/bin/tsc --noEmit",

src/operations/search_indexes/drop.ts

@@ -1,6 +1,7 @@
 import type { Document } from 'bson';
 
 import type { Collection } from '../../collection';
+import { MONGODB_ERROR_CODES, MongoServerError } from '../../error';
 import type { Server } from '../../sdam/server';
 import type { ClientSession } from '../../sessions';
 import { AbstractOperation } from '../operation';
@@ -22,7 +23,14 @@ export class DropSearchIndexOperation extends AbstractOperation<void> {
       command.name = this.name;
     }
 
-    await server.commandAsync(namespace, command, { session });
-    return;
+    try {
+      await server.commandAsync(namespace, command, { session });
+    } catch (error) {
+      const isNamespaceNotFoundError =
+        error instanceof MongoServerError && error.code === MONGODB_ERROR_CODES.NamespaceNotFound;
+      if (!isNamespaceNotFoundError) {
+        throw error;
+      }
+    }
   }
 }

test/manual/search-index-management.spec.test.ts renamed to test/integration/index-management/search-index-management.spec.test.ts

@@ -1,7 +1,7 @@
 import { join } from 'path';
 
-import { loadSpecTests } from '../spec';
-import { runUnifiedSuite } from '../tools/unified-spec-runner/runner';
+import { loadSpecTests } from '../../spec';
+import { runUnifiedSuite } from '../../tools/unified-spec-runner/runner';
 
 describe('Search Index Management Tests (Unified)', function () {
   runUnifiedSuite(loadSpecTests(join('index-management')));