Skip to content

Commit 804f996

Browse files
committed
test(NODE-6493): sync runCursorCommand fixes
1 parent 4265508 commit 804f996

File tree

3 files changed

+8
-10
lines changed

3 files changed

+8
-10
lines changed

test/integration/client-side-operations-timeout/client_side_operations_timeout.spec.test.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,9 @@ const skippedTests = {
1010
'timeoutMS can be configured on a MongoClient - createChangeStream on client': 'TODO(NODE-6305)',
1111
'timeoutMS applies to whole operation, not individual attempts - createChangeStream on client':
1212
'TODO(NODE-6305)',
13-
'Tailable cursor iteration timeoutMS is refreshed for getMore - failure': 'TODO(NODE-6305)',
1413
'Tailable cursor awaitData iteration timeoutMS is refreshed for getMore - failure':
1514
'TODO(NODE-6305)',
1615
'command is not sent if RTT is greater than timeoutMS': 'TODO(DRIVERS-2965)',
17-
'Non=tailable cursor iteration timeoutMS is refreshed for getMore if timeoutMode is iteration - failure':
18-
'TODO(DRIVERS-2965)',
1916
'Non-tailable cursor lifetime remaining timeoutMS applied to getMore if timeoutMode is unset':
2017
'TODO(DRIVERS-2965)',
2118
'maxTimeMS value in the command is less than timeoutMS':

test/spec/client-side-operations-timeout/runCursorCommand.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@
200200
},
201201
"collection": "collection",
202202
"maxTimeMS": {
203-
"$$exists": true
203+
"$$exists": false
204204
}
205205
}
206206
}
@@ -210,7 +210,7 @@
210210
]
211211
},
212212
{
213-
"description": "Non=tailable cursor iteration timeoutMS is refreshed for getMore if timeoutMode is iteration - failure",
213+
"description": "Non-tailable cursor iteration timeoutMS is refreshed for getMore if timeoutMode is iteration - failure",
214214
"runOnRequirements": [
215215
{
216216
"serverless": "forbid"

test/spec/client-side-operations-timeout/runCursorCommand.yml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ tests:
7070
runOnRequirements:
7171
- serverless: forbid
7272
operations:
73-
# Block find/getMore for 15ms.
73+
# Block find/getMore for 60ms.
7474
- name: failPoint
7575
object: testRunner
7676
arguments:
@@ -83,8 +83,9 @@ tests:
8383
blockConnection: true
8484
blockTimeMS: 60
8585
# Run a find with timeoutMS less than double our failPoint blockTimeMS and
86-
# batchSize less than the total document count will cause a find and a getMore to be sent.
87-
# Both will block for 60ms so together they will go over the timeout.
86+
# batchSize less than the total document count will cause a find and a
87+
# getMore to be sent. Both will block for 60ms so together they will go
88+
# over the timeout.
8889
- name: runCursorCommand
8990
object: *db
9091
arguments:
@@ -106,12 +107,12 @@ tests:
106107
command:
107108
getMore: { $$type: [int, long] }
108109
collection: *collection
109-
maxTimeMS: { $$exists: true }
110+
maxTimeMS: { $$exists: false }
110111

111112
# If timeoutMode=ITERATION, timeoutMS applies separately to the initial find and the getMore on the cursor. Neither
112113
# command should have a maxTimeMS field. This is a failure test. The "find" inherits timeoutMS=100 and "getMore"
113114
# commands are blocked for 60ms, causing iteration to fail with a timeout error.
114-
- description: Non=tailable cursor iteration timeoutMS is refreshed for getMore if timeoutMode is iteration - failure
115+
- description: Non-tailable cursor iteration timeoutMS is refreshed for getMore if timeoutMode is iteration - failure
115116
runOnRequirements:
116117
- serverless: forbid
117118
operations:

0 commit comments

Comments
 (0)