thresholds

Author: baileympearson

test/integration/client-side-operations-timeout/client_side_operations_timeout.prose.test.ts

@@ -21,7 +21,7 @@ import {
   promiseWithResolvers,
   squashError
 } from '../../mongodb';
-import { type FailPoint, makeMultiBatchWrite } from '../../tools/utils';
+import { type FailPoint, makeMultiBatchWrite, waitUntilPoolsFilled } from '../../tools/utils';
 import { filterForCommands } from '../shared';
 
 // TODO(NODE-5824): Implement CSOT prose tests
@@ -343,7 +343,7 @@ describe('CSOT spec prose tests', function () {
 
       client = this.configuration.newClient(undefined, {
         monitorCommands: true,
-        timeoutMS: 100,
+        timeoutMS: 150,
         minPoolSize: 20
       });
       await client.connect();

test/integration/crud/client_bulk_write.test.ts

@@ -320,7 +320,9 @@ describe('Client Bulk Write', function () {
 
         it(
           'timeoutMS is refreshed to the timeoutMS passed to the bulk write for the killCursors command',
-          metadata,
+          {
+            requires: { ...metadata.requires, topology: '!load-balanced' }
+          },
           async function () {
             const models = await makeMultiResponseBatchModelArray(this.configuration);
             const timeoutError = await client

test/integration/node-specific/abstract_cursor.test.ts

@@ -7,6 +7,7 @@ import { inspect } from 'util';
 import {
   AbstractCursor,
   type Collection,
+  type CommandStartedEvent,
   CursorTimeoutContext,
   CursorTimeoutMode,
   type FindCursor,
@@ -17,7 +18,8 @@ import {
   MongoServerError,
   TimeoutContext
 } from '../../mongodb';
-import { type FailPoint } from '../../tools/utils';
+import { clearFailPoint, configureFailPoint } from '../../tools/utils';
+import { filterForCommands } from '../shared';
 
 describe('class AbstractCursor', function () {
   describe('regression tests NODE-5372', function () {
@@ -405,9 +407,11 @@ describe('class AbstractCursor', function () {
     let client: MongoClient;
     let collection: Collection;
     let context: CursorTimeoutContext;
+    const commands: CommandStartedEvent[] = [];
 
     beforeEach(async function () {
-      client = this.configuration.newClient();
+      client = this.configuration.newClient({}, { monitorCommands: true });
+      client.on('commandStarted', filterForCommands('killCursors', commands));
 
       collection = client.db('abstract_cursor_integration').collection('test');
 
@@ -472,30 +476,48 @@ describe('class AbstractCursor', function () {
       });
     });
 
-    describe('when the cursor refreshes the timeout for killCursors', function () {
-      it(
-        'the provided timeoutContext is not modified',
-        {
-          requires: {
-            mongodb: '>=4.4'
-          }
-        },
-        async function () {
-          await client.db('admin').command({
+    describe('when the cursor refreshes the timeout for killCursors' + i, function () {
+      let uri: string;
+
+      before(function () {
+        uri = this.configuration.url({ useMultipleMongoses: false });
+      });
+
+      beforeEach(async function () {
+        commands.length = 0;
+        await configureFailPoint(
+          this.configuration,
+          {
             configureFailPoint: 'failCommand',
             mode: { times: 1 },
             data: {
               failCommands: ['getMore'],
               blockConnection: true,
               blockTimeMS: 5000
             }
-          } as FailPoint);
+          },
+          uri
+        );
+      });
 
+      afterEach(async function () {
+        await clearFailPoint(this.configuration, uri);
+      });
+
+      it(
+        'the provided timeoutContext is not modified' + i,
+        {
+          requires: {
+            mongodb: '>=4.4',
+            topology: '!load-balanced'
+          }
+        },
+        async function () {
           const cursor = collection.find(
             {},
             {
               timeoutContext: context,
-              timeoutMS: 1000,
+              timeoutMS: 150,
               timeoutMode: CursorTimeoutMode.LIFETIME,
               batchSize: 1
             }
@@ -504,7 +526,6 @@ describe('class AbstractCursor', function () {
           const error = await cursor.toArray().catch(e => e);
 
           expect(error).to.be.instanceof(MongoOperationTimeoutError);
-          // @ts-expect-error We know we have a CSOT timeout context but TS does not.
           expect(context.timeoutContext.remainingTimeMS).to.be.lessThan(0);
         }
       );

test/tools/utils.ts

@@ -601,8 +601,12 @@ export async function waitUntilPoolsFilled(
   await Promise.all([wait$(), client.connect()]);
 }
 
-export async function configureFailPoint(configuration: TestConfiguration, failPoint: FailPoint) {
-  const utilClient = configuration.newClient();
+export async function configureFailPoint(
+  configuration: TestConfiguration,
+  failPoint: FailPoint,
+  uri = configuration.url()
+) {
+  const utilClient = configuration.newClient(uri);
   await utilClient.connect();
 
   try {
@@ -612,8 +616,8 @@ export async function configureFailPoint(configuration: TestConfiguration, failP
   }
 }
 
-export async function clearFailPoint(configuration: TestConfiguration) {
-  const utilClient = configuration.newClient();
+export async function clearFailPoint(configuration: TestConfiguration, uri = configuration.url()) {
+  const utilClient = configuration.newClient(uri);
   await utilClient.connect();
 
   try {