refactor: refactor to keep change internal by removing option from BSONSerializeOptions and options registry

Author: Grace Chong

package-lock.json

@@ -51,10 +51,10 @@ export interface BSONSerializeOptions
       | 'cacheFunctionsCrc32'
       | 'allowObjectSmallerThanBufferSize'
       | 'index'
+      | 'validation'
     > {
   /** Return BSON filled buffers from operations */
   raw?: boolean;
-  validation?: { utf8: boolean | Record<string, true> | Record<string, false> };
 }
 
 export function pluckBSONSerializeOptions(options: BSONSerializeOptions): BSONSerializeOptions {

src/bson.ts

@@ -850,17 +850,17 @@ export class BinMsg {
       promoteLongs,
       promoteValues,
       promoteBuffers,
-      bsonRegExp,
-      validation
+      bsonRegExp
     };
 
     while (this.index < this.data.length) {
       const payloadType = this.data.readUInt8(this.index++);
       if (payloadType === 0) {
         const bsonSize = this.data.readUInt32LE(this.index);
         const bin = this.data.slice(this.index, this.index + bsonSize);
-        this.documents.push(raw ? bin : BSON.deserialize(bin, _options));
-
+        this.documents.push(
+          raw ? bin : BSON.deserialize(bin, Object.assign({ validation }, _options))
+        );
         this.index += bsonSize;
       } else if (payloadType === 1) {
         // It was decided that no driver makes use of payload type 1
@@ -874,8 +874,10 @@ export class BinMsg {
       const fieldsAsRaw: Document = {};
       fieldsAsRaw[documentsReturnedIn] = true;
       _options.fieldsAsRaw = fieldsAsRaw;
-
-      const doc = BSON.deserialize(this.documents[0] as Buffer, _options);
+      const doc = BSON.deserialize(
+        this.documents[0] as Buffer,
+        Object.assign({ validation }, _options)
+      );
       this.documents = [doc];
     }
 

src/cmap/commands.ts

@@ -864,10 +864,6 @@ export const OPTIONS = {
     default: false,
     type: 'boolean'
   },
-  validation: {
-    default: { utf8: { writeErrors: false } },
-    type: 'record'
-  },
   readConcern: {
     transform({ values: [value], options }) {
       if (value instanceof ReadConcern || isRecord(value, ['level'] as const)) {

src/connection_string.ts

@@ -21,8 +21,7 @@ type PermittedBSONOptionKeys =
   | 'promoteValues'
   | 'bsonRegExp'
   | 'fieldsAsRaw'
-  | 'raw'
-  | 'validation';
+  | 'raw';
 
 const keys = null as unknown as PermittedBSONOptionKeys;
 // creates an explicit allow list assertion