Check error contains

Author: prestonvasquez

internal/cmd/testatlas/atlas_test.go

@@ -31,91 +31,91 @@ func TestAtlas(t *testing.T) {
 		name        string
 		envVar      string
 		certKeyFile string
-		wantErrCode string
+		wantErr     string
 	}{
 		{
 			name:        "Atlas with TLS",
 			envVar:      "ATLAS_REPL",
 			certKeyFile: "",
-			wantErrCode: "",
+			wantErr:     "",
 		},
 		{
 			name:        "Atlas with TLS and shared cluster",
 			envVar:      "ATLAS_SHRD",
 			certKeyFile: "",
-			wantErrCode: "",
+			wantErr:     "",
 		},
 		{
 			name:        "Atlas with free tier",
 			envVar:      "ATLAS_FREE",
 			certKeyFile: "",
-			wantErrCode: "",
+			wantErr:     "",
 		},
 		{
 			name:        "Atlas with TLS 1.1",
 			envVar:      "ATLAS_TLS11",
 			certKeyFile: "",
-			wantErrCode: "",
+			wantErr:     "",
 		},
 		{
 			name:        "Atlas with TLS 1.2",
 			envVar:      "ATLAS_TLS12",
 			certKeyFile: "",
-			wantErrCode: "",
+			wantErr:     "",
 		},
 		{
 			name:        "Atlas with serverless",
 			envVar:      "ATLAS_SERVERLESS",
 			certKeyFile: "",
-			wantErrCode: "",
+			wantErr:     "",
 		},
 		{
 			name:        "Atlas with srv file on replica set",
 			envVar:      "ATLAS_SRV_REPL",
 			certKeyFile: "",
-			wantErrCode: "",
+			wantErr:     "",
 		},
 		{
 			name:        "Atlas with srv file on shared cluster",
 			envVar:      "ATLAS_SRV_SHRD",
 			certKeyFile: "",
-			wantErrCode: "",
+			wantErr:     "",
 		},
 		{
 			name:        "Atlas with srv file on free tier",
 			envVar:      "ATLAS_SRV_FREE",
 			certKeyFile: "",
-			wantErrCode: "",
+			wantErr:     "",
 		},
 		{
 			name:        "Atlas with srv file on TLS 1.1",
 			envVar:      "ATLAS_SRV_TLS11",
 			certKeyFile: "",
-			wantErrCode: "",
+			wantErr:     "",
 		},
 		{
 			name:        "Atlas with srv file on TLS 1.2",
 			envVar:      "ATLAS_SRV_TLS12",
 			certKeyFile: "",
-			wantErrCode: "",
+			wantErr:     "",
 		},
 		{
 			name:        "Atlas with srv file on serverless",
 			envVar:      "ATLAS_SRV_SERVERLESS",
 			certKeyFile: "",
-			wantErrCode: "",
+			wantErr:     "",
 		},
 		{
 			name:        "Atlas with X509 Dev",
 			envVar:      "ATLAS_X509_DEV",
 			certKeyFile: createAtlasX509DevCertKeyFile(t),
-			wantErrCode: "",
+			wantErr:     "",
 		},
 		{
 			name:        "Atlas with X509 Dev no user",
 			envVar:      "ATLAS_X509_DEV",
 			certKeyFile: createAtlasX509DevCertKeyFileNoUser(t),
-			wantErrCode: "11", // UserNotFound
+			wantErr:     "UserNotFound",
 		},
 	}
 
@@ -135,13 +135,8 @@ func TestAtlas(t *testing.T) {
 
 			// Run basic connectivity test.
 			err := runTest(context.Background(), clientOpts)
-			if tc.wantErrCode != "" {
-				var cmdErr *mongo.CommandError
-				if errors.As(err, &cmdErr) {
-					assert.Equal(t, cmdErr.Code, tc.wantErrCode)
-				} else {
-					t.Fatalf("expected error to be a command error, got: %v", err)
-				}
+			if tc.wantErr != "" {
+				assert.ErrorContains(t, err, tc.wantErr, "expected error to contain %q", tc.wantErr)
 
 				return
 			}