docs: dynamically generating tests with top-level await and ESM test files
#4617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juergba
added
area: documentation
juergba
force-pushed
the
juergba/docs-dynamic
branch
from
43739a6 to
5b421f0
Compare
outsideris
approved these changes
Apr 3, 2021
Contributor
outsideris
left a comment
outsideris
left a comment
There was a problem hiding this comment.
Wow! I didn't know that.
juergba
force-pushed
the
juergba/docs-dynamic
branch
from
5b421f0 to
951850f
Compare
juergba
added a commit
that referenced
this pull request
Apr 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
With
top-level awaittest data can be collected in a dynamic and asynchronous way, while the test file is loaded and before the testrunneris created. Since ESM files are already loaded in an asynchronous way, no changes to our code base are needed.Requisite:
top-level await: since Node >= v14.8.0ESM(ECMAScript module) test file