-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
chore(deps): upgrade all to latest stable #4556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bump all production deps to latest stable versions and regenerate lock file from scratch. `npm audit` on `master`: `found 39 vulnerabilities (30 low, 7 moderate, 2 high) in 2645 scanned packages` `npm audit` on branch: `found 3 low severity vulnerabilities in 2569 scanned packages`
juergba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AviVahl I pushed your branch to our repo, in order to run the browser test successfully.
The browser test doesn't work with github actions for PR's of forked repos.
juergba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description of the Change
bump all production deps to latest stable versions and regenerate lock file from scratch.
npm auditonmaster:found 39 vulnerabilities (30 low, 7 moderate, 2 high) in 2645 scanned packagesnpm auditon branch:found 3 low severity vulnerabilities in 2569 scanned packagesAlternate Designs
Why should this be in core?
Benefits
Improved audit result (for repo itself)
Possible Drawbacks
Any version upgrade is susceptible to regressions, especially in non-tested areas.
Applicable issues
#4533