Fix #4347 | Ensure root level hooks are called when running in watch mode #4382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
2 tasks
indieisaconcept
force-pushed
the
issue/4347
branch
from
c4db914 to
4ef171d
Compare
## Rationale Tests with root level hooks are ignored when running in watch mode. This occurs on initial & subsequent runs. ## Changes - updated `lib/cli/run-watch` to re-initialise rootHooks As we have swapped out the root suite it is necessary to re-initialize root level hooks again. - Extended integration tests for watch to take into consideration hooks ## Refs - mochajs/issues/4347
indieisaconcept
force-pushed
the
issue/4347
branch
from
4ef171d to
88fd011
Compare
indieisaconcept
changed the title
indieisaconcept
changed the title
boneskull
added
type: bug
2 tasks
boneskull
approved these changes
Jul 29, 2020
Member
boneskull
left a comment
boneskull
left a comment
There was a problem hiding this comment.
Thanks, LGTM. I'll see about cutting a release...hopefully.
4 tasks
Contributor
Author
|
Awesome. Thanks @boneskull |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Tests with root level hooks are ignored when running in watch mode.
This occurs on initial & subsequent runs.
Description of the Change
lib/cli/run-watchto re-initialise rootHooksAs we have swapped out the root suite it is necessary to re-initialize
root level hooks again.
hooks
Refs