Always enable BasePlan spaces (#35)

* Always use default space allocator

* Update mmtk

* update mmtk

* update mmtk-core

Author: wenyuzhao

mmtk/Cargo.toml

@@ -22,7 +22,7 @@ log = "*"
 # - change branch
 # - change repo name
 # But other changes including adding/removing whitespaces in commented lines may break the CI.
-mmtk = { git = "https://github.com/mmtk/mmtk-core.git", rev = "4bd6ca82ad037dac97920bf3a1408e4912a6bf04" }
+mmtk = { git = "https://github.com/mmtk/mmtk-core.git", rev = "4813a2bfc5322c526dc56e9f8acb418dbb7ce7e6" }
 # Uncomment the following and fix the path to mmtk-core to build locally
 # mmtk = { path = "../repos/mmtk-core" }
 

v8/third_party/heap/mmtk/mmtk.cc

@@ -121,9 +121,8 @@ AllocationResult Heap::Allocate(size_t size_in_bytes, AllocationType type, Alloc
   bool large_object = size_in_bytes > kMaxRegularHeapObjectSize;
   size_t align_bytes = (type == AllocationType::kCode) ? kCodeAlignment : (align == kWordAligned) ? kSystemPointerSize : (align == kDoubleAligned) ? kDoubleSize : kSystemPointerSize;
   // Get MMTk space that the object should be allocated to.
-  int space = (type == AllocationType::kCode) ? 3 : (type == AllocationType::kReadOnly) ? 4 : (large_object) ? 2 : 0;
   Address result =
-      reinterpret_cast<Address>(alloc(tph_mutator_, size_in_bytes, align_bytes, 0, space));
+      reinterpret_cast<Address>(alloc(tph_mutator_, size_in_bytes, align_bytes, 0, 0));
   // Remember the V8 internal `AllocationSpace` for this object.
   // This is required to pass various V8 internal space checks.
   // TODO(wenyuzhao): Use MMTk's vm-specific spaces for allocation instead of remembering the `AllocationSpace`s.