Merge pull request openshift#2054 from openshift-cherrypick-robot/cherry-pick-2052-to-release-4.18

openshift-merge-bot[bot] · web-flow · commit 4fcb2d07875f · 2025-07-07T12:26:58.000Z
[release-4.18] OCPBUGS-58233: Return error in case of error
diff --git a/pkg/cli/admin/nodeimage/create.go b/pkg/cli/admin/nodeimage/create.go
@@ -177,7 +177,7 @@ func (o *CreateOptions) AddFlags(cmd *cobra.Command) {
 func (o *CreateOptions) Complete(f kcmdutil.Factory, cmd *cobra.Command, args []string) error {
 	err := o.baseComplete(f)
 	if err != nil {
-		return nil
+		return err
 	}
 
 	if o.AssetsDir == "" {

Original file line number	Diff line number	Diff line change
`@@ -177,7 +177,7 @@ func (o CreateOptions) AddFlags(cmd cobra.Command) {`
`177`	`177`	`func (o CreateOptions) Complete(f kcmdutil.Factory, cmd cobra.Command, args []string) error {`
`178`	`178`	`err := o.baseComplete(f)`
`179`	`179`	`if err != nil {`
`180`		`- return nil`
	`180`	`+ return err`
`181`	`181`	`}`
`182`	`182`
`183`	`183`	`if o.AssetsDir == "" {`