Merge pull request #7205 from microting/copilot/fix-broken-cypress-tests

Fix Cypress tests by matching WDIO pattern - handle empty tables in rowNum() method

Author: renemadsen

eform-client/cypress/e2e/DeviceUsers.page.ts

@@ -86,7 +86,11 @@ class DeviceUsersPage extends PageWithNavbarPage{
   // @ts-ignore
   public rowNum(): Cypress.Chainable<number> {
     // @ts-ignore
-    return cy.get('tbody > tr').should('have.length.gt', 0).then($rows => $rows.length);
+    return cy.wait(500).then(() => {
+      return cy.get('tbody').then($tbody => {
+        return $tbody.find('tr').length;
+      });
+    });
   }
 
   public getDeviceUser(num: number): DeviceUsersRowObject {

eform-client/cypress/e2e/d/device-users.add.spec.cy.ts

@@ -21,9 +21,6 @@ describe('Device users page - Add new device user', function () {
   it('should add new device user with first name and last name', () => {
     const surname = generateRandmString();
 
-    // Ensure table is visible before counting rows
-    cy.get('tbody > tr', { timeout: 10000 }).should('have.length.gt', 0);
-    
     deviceUsersPage.rowNum().then((rowCountBeforeCreation) => {
       countDeviceUsersBeforeCreating = rowCountBeforeCreation;
 
@@ -37,7 +34,7 @@ describe('Device users page - Add new device user', function () {
       cy.get('#saveCreateBtn').should('be.visible').should('be.enabled').click();
       cy.wait('@createUser', { timeout: 30000 });
       cy.wait('@reloadDeviceUsers', { timeout: 30000 });
-      cy.get('#newDeviceUserBtn').should('be.visible');
+      cy.get('#newDeviceUserBtn', { timeout: 40000 }).should('be.visible');
 
       // Verify the user was created
       deviceUsersPage.rowNum().then((rowCountAfterCreation) => {
@@ -67,7 +64,7 @@ describe('Device users page - Should not add new device user', function () {
   it('should NOT add device user with only first name', () => {
     const name = generateRandmString();
 
-    cy.get('#newDeviceUserBtn').should('be.visible').click();
+    cy.get('#newDeviceUserBtn', { timeout: 40000 }).should('be.visible').click();
     cy.get('#firstName').should('be.visible').type(name);
 
     // Verify save button is disabled
@@ -80,38 +77,35 @@ describe('Device users page - Should not add new device user', function () {
   it('should NOT add device user with only last name', () => {
     const lastName = generateRandmString();
 
-    cy.get('#newDeviceUserBtn', { timeout: 10000 }).should('be.visible').click();
+    cy.get('#newDeviceUserBtn', { timeout: 40000 }).should('be.visible').click();
     cy.get('#lastName').should('be.visible').type(lastName);
 
     // Verify save button is disabled
     cy.get('#saveCreateBtn').should('be.disabled');
 
     cy.get('#cancelCreateBtn').should('be.visible').click();
-    cy.get('#newDeviceUserBtn', { timeout: 10000 }).should('be.visible');
+    cy.wait(500);
   });
 
   it('should NOT add device user without first and last names', () => {
-    cy.get('#newDeviceUserBtn', { timeout: 10000 }).should('be.visible').click();
+    cy.get('#newDeviceUserBtn', { timeout: 40000 }).should('be.visible').click();
+    cy.wait(500);
     cy.get('#firstName').should('be.visible');
 
     // Verify save button is disabled
     cy.get('#saveCreateBtn').should('be.disabled');
 
     cy.get('#cancelCreateBtn').should('be.visible').click();
-    cy.get('#newDeviceUserBtn', { timeout: 10000 }).should('be.visible');
     cy.wait(500);
   });
 
   it('should NOT create user if cancel was clicked', () => {
-    // Ensure table is visible before counting rows
-    cy.get('tbody > tr', { timeout: 10000 }).should('have.length.gt', 0);
-    
     deviceUsersPage.rowNum().then((rowCountBeforeCreation) => {
-      cy.get('#newDeviceUserBtn', { timeout: 10000 }).should('be.visible').click();
+      cy.get('#newDeviceUserBtn', { timeout: 40000 }).should('be.visible').click();
       cy.get('#firstName').should('be.visible');
       cy.wait(500);
       cy.get('#cancelCreateBtn').should('be.visible').click();
-      cy.get('#newDeviceUserBtn', { timeout: 10000 }).should('be.visible');
+      cy.get('#newDeviceUserBtn', { timeout: 40000 }).should('be.visible');
       cy.wait(500);
 
       deviceUsersPage.rowNum().then((rowCountAfterCreation) => {
@@ -124,9 +118,6 @@ describe('Device users page - Should not add new device user', function () {
   });
 
   it('should clean up created test data', () => {
-    // Ensure table is visible before finding user
-    cy.get('tbody > tr', { timeout: 10000 }).should('have.length.gt', 0);
-    
     // Find and delete the test user
     cy.get('#deviceUserFirstName').each(($el, index) => {
       if ($el.text() === nameDeviceUser) {
@@ -136,13 +127,10 @@ describe('Device users page - Should not add new device user', function () {
         cy.get('#saveDeleteBtn').should('be.visible').click();
         cy.wait('@deleteUser', { timeout: 30000 });
         cy.wait('@reloadDeviceUsers', { timeout: 30000 });
-        cy.get('#newDeviceUserBtn', { timeout: 10000 }).should('be.visible');
+        cy.get('#newDeviceUserBtn', { timeout: 40000 }).should('be.visible');
         return false; // break the loop
       }
     });
-
-    // Ensure table is visible before counting rows
-    cy.get('tbody > tr', { timeout: 10000 }).should('have.length.gt', 0);
 
     // Verify count is back to original
     deviceUsersPage.rowNum().then((currentCount) => {