fix(selector generator): heuristic for icon fonts #38182
Merged
+21
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A common technique used for icon fonts is to prepend a
`::before { content: "..." }` pseudo with a character from
a unicode private use area, and define an icon rendering for
such a character.
Using such a character as accessible name in `getByRole()`
is not very readable, so avoid that.
yury-s
approved these changes
Nov 11, 2025
Contributor
Test results for "MCP"1 failed 2639 passed, 116 skipped Merge workflow run. |
Contributor
Test results for "tests 1"5 flaky40213 passed, 787 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A common technique used for icon fonts is to prepend a
::before { content: "..." }pseudo with a character from a unicode private use area, and define an icon rendering for such a character.Using such a character as accessible name in
getByRole()is not very readable, so avoid that.Fixes #38173.