Migrate TwineAuthenticateV0-1 to Node 10 (#15924)

* migrate TwineAuthenticateV0 to Node 10

* migrate task TwineAuthenticateV1 to Node 10

* bump version

* fixed tests

* increase timeout for test

* Fix test call

* Bump TwineAuthenticateV0/V2 Task version from 207 to 208

Co-authored-by: Andrey Ivanov <[email protected]>
Co-authored-by: Dmitrii Bobreshev <[email protected]>
Co-authored-by: tintse-thxsky-MSFT <[email protected]>

Author: 4 people

Tasks/TwineAuthenticateV0/Tests/L0.ts

@@ -9,7 +9,7 @@ describe('TwineAuthenticateV1 Suite', function () {
     after(() => {
     });
 
-    it('Does a basic hello world test', function(done: MochaDone) {
+    it('Does a basic hello world test', function(done: Mocha.Done) {
         // TODO - add real tests
         done();
     });

Tasks/TwineAuthenticateV0/package-lock.json

@@ -17,10 +17,16 @@
     },
     "homepage": "https://github.com/Microsoft/azure-pipelines-tasks#readme",
     "dependencies": {
-        "azure-pipelines-task-lib": "2.8.0",
-        "ini": "1.3.8",
+        "@types/mocha": "^5.2.7",
+        "@types/node": "^10.17.0",
+        "@types/uuid": "^8.3.0",
+        "azure-pipelines-task-lib": "^3.1.7",
+        "ini": "^1.3.6",
         "packaging-common": "file:../../_build/Tasks/Common/packaging-common-1.0.1.tgz",
         "typed-rest-client": "^0.11.0",
         "utility-common": "file:../../_build/Tasks/Common/utility-common-1.0.2.tgz"
+    },
+    "devDependencies": {
+        "typescript": "4.0.2"
     }
 }

Tasks/TwineAuthenticateV0/package.json

@@ -10,13 +10,13 @@
     "version": {
         "Major": 0,
         "Minor": 208,
-        "Patch": 1
+        "Patch": 2
     },
     "runsOn": [
         "Agent",
         "DeploymentGroup"
     ],
-    "minimumAgentVersion": "2.115.0",
+    "minimumAgentVersion": "2.144.0",
     "instanceNameFormat": "Twine Authenticate $(message)",
     "groups": [
         {
@@ -81,7 +81,7 @@
         }
     ],
     "execution": {
-        "Node": {
+        "Node10": {
             "target": "twineauthenticatemain.js",
             "argumentFormat": ""
         }
@@ -106,7 +106,7 @@
         "Warning_SessionCreationFailed": "Could not create provenance session: %s"
     },
     "postjobexecution": {
-        "Node": {
+        "Node10": {
             "target": "authcleanup.js",
             "argumentFormat": ""
         }

Tasks/TwineAuthenticateV0/task.json

@@ -10,10 +10,10 @@
   "version": {
     "Major": 0,
     "Minor": 208,
-    "Patch": 1
+    "Patch": 2
   },
   "runsOn": ["Agent", "DeploymentGroup"],
-  "minimumAgentVersion": "2.115.0",
+  "minimumAgentVersion": "2.144.0",
   "instanceNameFormat": "ms-resource:loc.instanceNameFormat",
   "groups": [
     {
@@ -74,7 +74,7 @@
     }
   ],
   "execution": {
-    "Node": {
+    "Node10": {
       "target": "twineauthenticatemain.js",
       "argumentFormat": ""
     }
@@ -99,7 +99,7 @@
     "Warning_SessionCreationFailed": "ms-resource:loc.messages.Warning_SessionCreationFailed"
   },
   "postjobexecution": {
-    "Node": {
+    "Node10": {
       "target": "authcleanup.js",
       "argumentFormat": ""
     }

Tasks/TwineAuthenticateV0/task.loc.json

@@ -16,28 +16,28 @@ describe('Twine Authenticate V1 Suite', function () {
         tl.rmRF(tempDir);
     });
 
-    it('sets authentication for current organization feed', (done: MochaDone) => {
-        this.timeout(1000);
+    it('sets authentication for current organization feed', function (done: Mocha.Done) {
+        this.timeout(5000);
         let tp = path.join(__dirname, './setAuthInternalFeed.js')
         let tr: ttm.MockTestRunner = new ttm.MockTestRunner(tp);
 
         tr.run();
         assert(tr.invokedToolCount == 0, 'no tool should be invoked.');
         assert(tr.succeeded, 'should have succeeded');
-        assert.equal(tr.errorIssues.length, 0, "should have no errors");
+        assert.strictEqual(tr.errorIssues.length, 0, "should have no errors");
         let fileContent = ini.parse(fs.readFileSync(tempDir + path.sep + ".pypirc", "utf-8"));
 
-        assert.equal(fileContent["distutils"]["index-servers"], "TestFeed", "Test Feed should be added to auth list.");
+        assert.strictEqual(fileContent["distutils"]["index-servers"], "TestFeed", "Test Feed should be added to auth list.");
 
-        assert.equal(fileContent["TestFeed"]["repository"],
+        assert.strictEqual(fileContent["TestFeed"]["repository"],
         "https://vsts/packagesource/TestFeed",
         "Test Feed repository should be correct.");
 
-        assert.equal(fileContent["TestFeed"]["username"],
+        assert.strictEqual(fileContent["TestFeed"]["username"],
         "build",
         "Default username should be correct.");
 
-        assert.equal(fileContent["TestFeed"]["password"],
+        assert.strictEqual(fileContent["TestFeed"]["password"],
         "token",
         "Default password from environment variable should be correct.");