fix an issue with no declarated setter param in JS files

Author: Andarist

src/compiler/checker.ts

@@ -9805,7 +9805,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
                             });
 
                             Debug.assert(setter && isFunctionLikeDeclaration(setter));
-                            const paramSymbol = getSignatureFromDeclaration(setter).parameters[0];
+                            const paramSymbol: Symbol | undefined = getSignatureFromDeclaration(setter).parameters[0];
 
                             result.push(setTextRange(
                                 factory.createSetAccessorDeclaration(
@@ -9814,7 +9814,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
                                     [factory.createParameterDeclaration(
                                         /*modifiers*/ undefined,
                                         /*dotDotDotToken*/ undefined,
-                                        parameterToParameterDeclarationName(paramSymbol, getEffectiveParameterDeclaration(paramSymbol), context),
+                                        paramSymbol ? parameterToParameterDeclarationName(paramSymbol, getEffectiveParameterDeclaration(paramSymbol), context) : "value",
                                         /*questionToken*/ undefined,
                                         isPrivate ? undefined : serializeTypeForDeclaration(context, getTypeOfSymbol(p), p, enclosingDeclaration, includePrivateSymbol, bundled),
                                     )],

tests/baselines/reference/jsDeclarationsGetterSetter.js

@@ -56,6 +56,11 @@ Object.defineProperty(G.prototype, "x", {
      */
     set(...args) {}
 });
+
+export class H {}
+Object.defineProperty(H.prototype, "x", {
+    set() {}
+});
 
 
 //// [index.js]
@@ -112,6 +117,11 @@ Object.defineProperty(G.prototype, "x", {
      */
     set(...args) { }
 });
+export class H {
+}
+Object.defineProperty(H.prototype, "x", {
+    set() { }
+});
 
 
 //// [index.d.ts]
@@ -141,3 +151,6 @@ export class F {
 export class G {
     set x(args: number);
 }
+export class H {
+    set x(value: any);
+}

tests/baselines/reference/jsDeclarationsGetterSetter.symbols

@@ -124,3 +124,20 @@ Object.defineProperty(G.prototype, "x", {
 
 });
 
+export class H {}
+>H : Symbol(H, Decl(index.js, 54, 3))
+
+Object.defineProperty(H.prototype, "x", {
+>Object.defineProperty : Symbol(ObjectConstructor.defineProperty, Decl(lib.es5.d.ts, --, --))
+>Object : Symbol(Object, Decl(lib.es5.d.ts, --, --), Decl(lib.es5.d.ts, --, --))
+>defineProperty : Symbol(ObjectConstructor.defineProperty, Decl(lib.es5.d.ts, --, --))
+>H.prototype : Symbol(H.prototype)
+>H : Symbol(H, Decl(index.js, 54, 3))
+>prototype : Symbol(H.prototype)
+>"x" : Symbol(H.x, Decl(index.js, 56, 17))
+
+    set() {}
+>set : Symbol(set, Decl(index.js, 57, 41))
+
+});
+

tests/baselines/reference/jsDeclarationsGetterSetter.types

@@ -137,3 +137,22 @@ Object.defineProperty(G.prototype, "x", {
 
 });
 
+export class H {}
+>H : H
+
+Object.defineProperty(H.prototype, "x", {
+>Object.defineProperty(H.prototype, "x", {    set() {}}) : H
+>Object.defineProperty : <T>(o: T, p: PropertyKey, attributes: PropertyDescriptor & ThisType<any>) => T
+>Object : ObjectConstructor
+>defineProperty : <T>(o: T, p: PropertyKey, attributes: PropertyDescriptor & ThisType<any>) => T
+>H.prototype : H
+>H : typeof H
+>prototype : H
+>"x" : "x"
+>{    set() {}} : { set(): void; }
+
+    set() {}
+>set : () => void
+
+});
+

tests/cases/conformance/jsdoc/declarations/jsDeclarationsGetterSetter.ts

@@ -59,3 +59,8 @@ Object.defineProperty(G.prototype, "x", {
      */
     set(...args) {}
 });
+
+export class H {}
+Object.defineProperty(H.prototype, "x", {
+    set() {}
+});