Skip to content

Conversation

@halfninja
Copy link
Contributor

Before we reassign a number variable to a string, check it is still actually a number

@clayreimann
Copy link
Collaborator

@halfninja Can you share possible values for what testcase.attr.time would actually be in this case? Also, please add a regression test to ensure we don't break this again in the future.

@halfninja
Copy link
Contributor Author

@halfninja Can you share possible values for what testcase.attr.time would actually be in this case? Also, please add a regression test to ensure we don't break this again in the future.

It's either a number like 6.54321 or a fixed-decimal string like "6.543". I'll have another go at a test.

@halfninja
Copy link
Contributor Author

I've added a test case that was failing without the fix. As I don't know exactly how Cypress gets into this situation it directly calls getXml with some test data crafted to hit the error.

@clayreimann clayreimann merged commit 4c2bc93 into michaelleeallen:master Sep 27, 2022
@BenFranzi
Copy link

Can you please publish this change to npm

@clayreimann
Copy link
Collaborator

@BenFranzi now on npm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants