feat: test alias usage for custom jmx metrics

Author: ekremsekerci

buildpack/telemetry/datadog.py

@@ -22,6 +22,7 @@
 from buildpack import util
 from buildpack.core import runtime
 from buildpack.infrastructure import database
+from buildpack.telemetry.metrics import deny_all_apm_metrics
 from lib.m2ee.version import MXVersion
 from lib.m2ee.util import strtobool
 
@@ -253,7 +254,7 @@ def _set_up_dd_java_agent(m2ee, model_version, runtime_version, jmx_config_files
     util.upsert_javaopts(
         m2ee,
         [
-            "-Ddd.jmxfetch.enabled=true",
+            f"-Ddd.jmxfetch.enabled=true",
             f"-Ddd.jmxfetch.statsd.port={get_statsd_port()}",
         ],
     )
@@ -287,7 +288,7 @@ def _get_runtime_jmx_config(extra_jmx_instance_config=None):
                             # NamedUserSessions = 0;
                             # AnonymousSessions = 0;
                             "attribute": {
-                                "NamedUsers": {"metrics_type": "gauge"},
+                                "NamedUsers": {"metrics_type": "gauge", "alias": "mx.ekrem_test_named_users"},
                                 "NamedUserSessions": {"metrics_type": "gauge"},
                                 "AnonymousSessions": {"metrics_type": "gauge"},
                             },
@@ -493,18 +494,19 @@ def update_config(
             },
         )
 
-    # Set up runtime JMX configuration
-    with open(_get_jmx_conf_file(), "w") as file_handler:
-        file_handler.write(
-            yaml.safe_dump(
-                _get_runtime_jmx_config(
-                    extra_jmx_instance_config=extra_jmx_instance_config,
+    if not deny_all_apm_metrics():
+        # Set up runtime JMX configuration
+        with open(_get_jmx_conf_file(), "w") as file_handler:
+            file_handler.write(
+                yaml.safe_dump(
+                    _get_runtime_jmx_config(
+                        extra_jmx_instance_config=extra_jmx_instance_config,
+                    )
                 )
             )
-        )
+        jmx_config_files.append(_get_jmx_conf_file())
 
     # Set up Datadog Java Trace Agent
-    jmx_config_files.append(_get_jmx_conf_file())
     _set_up_dd_java_agent(
         m2ee,
         model_version,