Support testing with remotes

Author: ellnix

CONTRIBUTING.md

@@ -34,10 +34,14 @@ First of all, thank you for contributing to Meilisearch! The goal of this docume
 
 You can set up your local environment natively or using `docker`, check out the [`docker-compose.yml`](/docker-compose.yml).
 
+#### With Docker <!-- omit in toc -->
 Example of running all the checks with docker:
 ```bash
 docker-compose run --rm package bash -c "bundle install && bundle exec rspec && bundle exec rubocop"
 ```
+<!-- need to run multiple instances of meilisearch for proxy tests -->
+
+#### Locally <!-- omit in toc -->
 
 To install dependencies:
 ```bash
@@ -51,7 +55,12 @@ Each PR should pass the tests to be accepted.
 ```bash
 # Tests
 curl -L https://install.meilisearch.com | sh # download Meilisearch
-./meilisearch --master-key=masterKey --no-analytics # run Meilisearch
+
+# run Meilisearch
+./meilisearch --master-key=masterKey --no-analytics
+# run a second instance of Meilisearch to act as proxy
+./meilisearch --master-key=masterKey --no-analytics --http-addr localhost:7701
+
 bundle exec rspec
 ```
 

docker-compose.yml

@@ -10,19 +10,29 @@ services:
     environment:
       - MEILISEARCH_URL=meilisearch
       - MEILISEARCH_PORT=7700
+      - MEILISEARCH_REMOTE_URL=meilisearch_remote
+      - MEILISEARCH_REMOTE_PORT=7701
       - BUNDLE_PATH=/vendor/bundle
     depends_on:
       - meilisearch
-    links:
-      - meilisearch
+      - meilisearch_remote
     volumes:
       - ./:/home/package
       - bundle:/vendor/bundle
 
   meilisearch:
-    image: getmeili/meilisearch:latest
+    image: getmeili/meilisearch:nightly
     ports:
       - "7700"
     environment:
       - MEILI_MASTER_KEY=masterKey
       - MEILI_NO_ANALYTICS=true
+
+  meilisearch_remote:
+    image: getmeili/meilisearch:nightly
+    ports:
+      - "7701"
+    environment:
+      - MEILI_MASTER_KEY=masterKey
+      - MEILI_NO_ANALYTICS=true
+    command: ["meilisearch", "--http-addr", "0.0.0.0:7701"]

spec/meilisearch/client/multi_search_spec.rb

@@ -75,4 +75,61 @@
     expect(hits.size).to be 3
     expect(hits.first).to have_key('_federation')
   end
+
+  describe 'searching multiple remotes' do
+    it 'federated search searches multiple remotes' do
+      client.update_experimental_features(network: true)
+      proxy_client.update_experimental_features(network: true)
+
+      client.update_network(
+        self: 'ms0',
+        remotes: {
+          ms2: {
+            url: PROXY_URL,
+            search_api_key: MASTER_KEY
+          }
+        }
+      )
+
+      three_body_problem = { id: 1, title: 'The Three Body Problem' }
+      the_dark_forest = { id: 2, title: 'The Dark Forest' }
+      proxy_client.index('books').add_documents([three_body_problem, the_dark_forest]).await
+
+      sherwood_forest = { id: 50, name: 'Sherwood Forest' }
+      forbidden_forest = { id: 200, name: 'Forbidden Forest' }
+      client.index('parks').add_documents([sherwood_forest, forbidden_forest]).await
+
+      response = client.multi_search(
+        federation: {},
+        queries: [
+          {
+            q: 'Forest',
+            index_uid: 'parks',
+            federation_options: {
+              remote: 'ms0'
+            }
+          },
+          {
+            q: 'Body',
+            index_uid: 'books',
+            federation_options: {
+              remote: 'ms2'
+            }
+          }
+        ]
+      )
+
+      resp = response['hits'].map { |hit| hit.slice('id', 'name', 'title').transform_keys(&:to_sym) }
+
+      expect(resp).to include(three_body_problem, sherwood_forest, forbidden_forest)
+      expect(resp).not_to include(the_dark_forest)
+    rescue Meilisearch::CommunicationError
+      pending('Please launch a second instance of Meilisearch to test network search, see spec_helper for addr config.')
+      raise
+    ensure
+      client.update_network(self: nil, remotes: nil)
+      client.delete_index('parks')
+      proxy_client.delete_index('books')
+    end
+  end
 end

spec/spec_helper.rb

@@ -42,6 +42,11 @@
 # Globals for all tests
 URL = format('http://%<host>s:%<port>s',
              host: ENV.fetch('MEILISEARCH_URL', 'localhost'), port: ENV.fetch('MEILISEARCH_PORT', '7700'))
+
+PROXY_URL = format('http://%<host>s:%<port>s',
+                   host: ENV.fetch('MEILISEARCH_REMOTE_URL', 'localhost'),
+                   port: ENV.fetch('MEILISEARCH_REMOTE_PROXY', '7701'))
+
 MASTER_KEY = 'masterKey'
 DEFAULT_SEARCH_RESPONSE_KEYS = [
   'hits',

spec/support/default_shared_context.rb

@@ -2,6 +2,7 @@
 
 RSpec.shared_context 'test defaults' do
   let(:client) { Meilisearch::Client.new(URL, MASTER_KEY, { timeout: 2, max_retries: 1 }) }
+  let(:proxy_client) { Meilisearch::Client.new(PROXY_URL, MASTER_KEY, { timeout: 2, max_retries: 1 }) }
 
   before do
     clear_all_indexes(client)