Skip to content

Disable code-cov #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 15, 2024
Merged

Disable code-cov #913

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ddd2f9
Disable code-cov
sanders41 Jan 15, 2024
de84e52
Merge remote-tracking branch 'origin/main' into code-cov
sanders41 Jan 15, 2024
6511a81
Completely remove code-cov
sanders41 Jan 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,14 @@ jobs:
- name: Meilisearch (latest version) setup with Docker
run: docker run -d -p 7700:7700 getmeili/meilisearch:latest meilisearch --no-analytics --master-key=masterKey
- name: Test with pytest
run: pipenv run pytest --cov-report=xml
- name: Upload coverage
uses: codecov/codecov-action@v3
with:
fail_ci_if_error: true
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
run:
pipenv run pytest --cov-report=xml
# - name: Upload coverage
# uses: codecov/codecov-action@v3
# with:
# fail_ci_if_error: true
# env:
# CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
Copy link
Member

@curquiza curquiza Jan 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# - name: Upload coverage
# uses: codecov/codecov-action@v3
# with:
# fail_ci_if_error: true
# env:
# CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

Copy link
Member

@curquiza curquiza Jan 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would go with completely remove them, and mention in the PR in the issue we will open to say we want something else than code coverage


pylint:
name: pylint
Expand Down