Merge #530

530: Add compatibility with instantsearch types r=bidoubiwa a=bidoubiwa

fixes: #529 
fixes: #460 
fixes: #517 

Co-authored-by: Charlotte Vermandel <[email protected]>

Author: bors[bot]

.github/workflows/test.yml

@@ -28,13 +28,13 @@ jobs:
         with:
           node-version: '12.x'
       - name: Install dependencies
-        run: yarn --dev && yarn --cwd ./playgrounds/react
+        run: yarn --dev && yarn --cwd ./playgrounds/vue
       - name: Run Browser tests
         uses: cypress-io/github-action@v2
         with:
           # Tests are only done on one playground to avoid long testing time
-          start: yarn playground:react
-          env: playground=react
+          start: yarn playground:vue
+          env: playground=vue
       - uses: actions/upload-artifact@v1
         if: failure()
         with:

.gitignore

@@ -118,3 +118,4 @@ cypress/support
 cypress/plugins
 cypress/fixtures
 
+.vscode

package.json

@@ -8,9 +8,9 @@
     "test:watch": "yarn test --watch",
     "test": "jest --runInBand --selectProjects dom --selectProjects node",
     "test:build": "yarn build && jest --runInBand --selectProjects build",
-    "test:e2e": "concurrently --kill-others -s first \"NODE_ENV=test yarn playground:javascript\" \"cypress run --env playground=javascript\"",
+    "test:e2e": "concurrently --kill-others -s first \"NODE_ENV=test yarn playground:angular\" \"cypress run --env playground=angular\"",
     "test:e2e:all": "sh scripts/e2e.sh",
-    "test:e2e:watch": "concurrently --kill-others -s first \"NODE_ENV=test yarn playground:javascript\" \"cypress open --env playground=javascript\"",
+    "test:e2e:watch": "concurrently --kill-others -s first \"NODE_ENV=test yarn playground:angular\" \"cypress open --env playground=angular\"",
     "test:all": "yarn test:e2e:all && yarn test && test:build",
     "cy:open": "cypress open",
     "playground:vue": "yarn --cwd ./playgrounds/vue && yarn --cwd ./playgrounds/vue serve",
@@ -53,20 +53,22 @@
     "url": "https://github.com/meilisearch/instant-meilisearch.git"
   },
   "dependencies": {
-    "meilisearch": "^0.20.1"
+    "meilisearch": "^0.21.0"
   },
   "devDependencies": {
     "@babel/cli": "^7.15.7",
     "@babel/core": "^7.15.5",
     "@babel/preset-env": "^7.15.6",
     "@rollup/plugin-commonjs": "^17.1.0",
     "@rollup/plugin-node-resolve": "^11.2.0",
+    "@types/jest": "^27.0.2",
     "@typescript-eslint/eslint-plugin": "^4.16.1",
     "@typescript-eslint/parser": "^4.16.1",
     "@vue/eslint-config-typescript": "^7.0.0",
     "@vue/eslint-plugin": "^4.2.0",
+    "algoliasearch": "^4.10.5",
     "babel-eslint": "^10.1.0",
-    "babel-jest": "^26.1.0",
+    "babel-jest": "^27.2.2",
     "concurrently": "^6.2.1",
     "cssnano": "^4.1.10",
     "cypress": "^7.3.0",
@@ -86,7 +88,7 @@
     "eslint-plugin-standard": "^5.0.0",
     "eslint-plugin-vue": "^7.7.0",
     "instantsearch.js": "^4.30.1",
-    "jest": "^26.6.3",
+    "jest": "^27.2.2",
     "jest-watch-typeahead": "^0.6.3",
     "prettier": "^2.0.0",
     "regenerator-runtime": "^0.13.7",
@@ -96,8 +98,8 @@
     "rollup-plugin-terser": "^7.0.0",
     "rollup-plugin-typescript2": "^0.30.0",
     "shx": "^0.3.3",
-    "ts-jest": "^26.5.2",
+    "ts-jest": "^27.0.5",
     "tslib": "^2.3.1",
-    "typescript": "^4.3.5"
+    "typescript": "^4.4.3"
   }
 }

playgrounds/angular/package.json

@@ -16,7 +16,8 @@
     "@angular/platform-browser": "~11.2.2",
     "@angular/platform-browser-dynamic": "~11.2.2",
     "@angular/router": "~11.2.2",
-    "angular-instantsearch": "^3.0.0-beta.5",
+    "algoliasearch": "^4.10.5",
+    "angular-instantsearch": "^4.0.0",
     "instantsearch.css": "^7.4.5",
     "instantsearch.js": "^4.14.0",
     "rxjs": "~6.6.0",

playgrounds/angular/tsconfig.json

@@ -8,14 +8,29 @@
     "declaration": false,
     "downlevelIteration": true,
     "experimentalDecorators": true,
+    "allowSyntheticDefaultImports": true,
     "moduleResolution": "node",
     "importHelpers": true,
     "target": "es2015",
     "module": "es2020",
     "lib": [
       "es2020",
       "dom"
-    ]
+    ],
+    // Enforced typing rules
+    "strict": true,
+    "noImplicitAny": true,
+    "strictNullChecks": true,
+    "strictFunctionTypes": true,
+    "strictPropertyInitialization": true,
+    "strictBindCallApply": true,
+    "noImplicitThis": true,
+    "noImplicitReturns": true,
+    "alwaysStrict": true,
+    "emitDecoratorMetadata": true,
+    "forceConsistentCasingInFileNames": true,
+    "noUnusedLocals": false,
+    "noUnusedParameters": true,
   },
   "angularCompilerOptions": {
     "enableI18nLegacyMessageIdFormat": false