Skip to content

Conversation

@maxkur
Copy link
Contributor

@maxkur maxkur commented Sep 7, 2020

Обновлены модули и Go.
Обновлены структуры.
Добавлены недостающие поля.
Добавлен маршалинг составных тегов и атрибутов типа cenc:pssh

@maxkur maxkur changed the title Update structs and marshal for component tag and attr [WIP]Update structs and marshal for component tag and attr Sep 7, 2020
@maxkur maxkur changed the title [WIP]Update structs and marshal for component tag and attr Update structs and marshal for component tag and attr Sep 7, 2020
@maxkur maxkur requested a review from bikbah September 8, 2020 09:41
Copy link

@avhitrov avhitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Экономим время и память

mpd.go Outdated
return asm
}

func modifyRepresentations(rs []Representation) (rsm []representationMarshal) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
func modifyRepresentations(rs []Representation) (rsm []representationMarshal) {
func modifyRepresentations(rs []Representation) []representationMarshal {
rsm := make([]representationMarshal, 0, len(rs))

mpd.go Outdated
}
}

func copySegmentTimelineS(st []SegmentTimelineS) (stm []SegmentTimelineS) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
func copySegmentTimelineS(st []SegmentTimelineS) (stm []SegmentTimelineS) {
func copySegmentTimelineS(st []SegmentTimelineS) []SegmentTimelineS {
stm := make([]SegmentTimelineS, 0, len(st))

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

И дальше по коду

@maxkur maxkur requested a review from avhitrov September 8, 2020 22:06
.travis.yml Outdated

go:
- 1.12.x
- 1.13.x
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

удаляем

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Зачем удалять? Он же работает - https://travis-ci.org/mc2soft/mpd

utils/copyjob.go Outdated
@@ -0,0 +1,34 @@
package utils
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package copyobj

@maxkur maxkur merged commit 990e510 into master Sep 9, 2020
@TobbeEdgeware TobbeEdgeware mentioned this pull request Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants