-
Notifications
You must be signed in to change notification settings - Fork 35
Update structs and marshal for component tag and attr #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
avhitrov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Экономим время и память
mpd.go
Outdated
| return asm | ||
| } | ||
|
|
||
| func modifyRepresentations(rs []Representation) (rsm []representationMarshal) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| func modifyRepresentations(rs []Representation) (rsm []representationMarshal) { | |
| func modifyRepresentations(rs []Representation) []representationMarshal { | |
| rsm := make([]representationMarshal, 0, len(rs)) |
mpd.go
Outdated
| } | ||
| } | ||
|
|
||
| func copySegmentTimelineS(st []SegmentTimelineS) (stm []SegmentTimelineS) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| func copySegmentTimelineS(st []SegmentTimelineS) (stm []SegmentTimelineS) { | |
| func copySegmentTimelineS(st []SegmentTimelineS) []SegmentTimelineS { | |
| stm := make([]SegmentTimelineS, 0, len(st)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
И дальше по коду
.travis.yml
Outdated
|
|
||
| go: | ||
| - 1.12.x | ||
| - 1.13.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
удаляем
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Зачем удалять? Он же работает - https://travis-ci.org/mc2soft/mpd
utils/copyjob.go
Outdated
| @@ -0,0 +1,34 @@ | |||
| package utils | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
package copyobj
Обновлены модули и Go.
Обновлены структуры.
Добавлены недостающие поля.
Добавлен маршалинг составных тегов и атрибутов типа
cenc:pssh