Clarify that join_authorised_via_users_server auth event is only necessary for joins
#2100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cessary for join Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Johennes
pushed a commit
to Johennes/matrix-spec
that referenced
this pull request
May 30, 2025
…cessary for `join`s (matrix-org#2100) Signed-off-by: Kévin Commaille <[email protected]>
35 tasks
34 tasks
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the field is only checked in the authorization rules when the
membershipisjoin: 4.3.5 in room v11.This matches the behavior of Synapse: https://github.com/element-hq/synapse/blob/51df675c054369576ed9bde8d1865c904fa6056c/synapse/event_auth.py#L1176
Pull Request Checklist
Preview: https://pr2100--matrix-spec-previews.netlify.app