Clarify allowed HTTP methods in CORS responses (take 2) #2011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
richvdh
approved these changes
Dec 10, 2024
Member
richvdh
left a comment
richvdh
left a comment
There was a problem hiding this comment.
This looks plausible to me, but I'd quite like a double-check from @turt2live as the author of matrix-org/matrix-spec-proposals#4187 to confirm it matches expectations.
turt2live
approved these changes
Dec 11, 2024
Member
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
This indeed matches the intent of the MSC's intent - thank you!
26 tasks
43 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #1995, this time using the updated MSC4138 text from matrix-org/matrix-spec-proposals#4187.
Pull Request Checklist
Preview: https://pr2011--matrix-spec-previews.netlify.app