Spec ?animated on /thumbnail
#1757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
reviewed
Mar 26, 2024
Member
richvdh
left a comment
richvdh
left a comment
There was a problem hiding this comment.
Could you merge the latest changes from main so we can see how this looks in the preview?
richvdh
reviewed
Mar 27, 2024
Comment on lines
+679
to
+680
| x-changedInMatrixVersion: | ||
| "1.11": The PNG may be of the APNG variety if animation is supported and requested. |
Member
There was a problem hiding this comment.
For the record (no action required): these don't seem to show up in the rendered spec, though that's no reason not to add them.
richvdh
approved these changes
Mar 27, 2024
This was referenced Apr 19, 2024
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better with #1756
See matrix-org/matrix-spec-proposals#2705
Preview: https://pr1757--matrix-spec-previews.netlify.app