Skip to content

Conversation

@UziTech
Copy link
Member

@UziTech UziTech commented Apr 12, 2019

Marked version: master

Markdown flavor: GitHub Flavored Markdown

Description

Update gfm specs to 0.29

Contributor

  • Test(s) exist to ensure functionality and minimize regression

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

"html": "<table>\n<thead>\n<tr>\n<th>foo</th>\n<th>bar</th>\n</tr>\n</thead>\n<tbody>\n<tr>\n<td>baz</td>\n<td>bim</td>\n</tr>\n</tbody>\n</table>",
"markdown": "| foo | bar |\n| --- | --- |\n| baz | bim |",
"example": 191
"example": "198"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it matter if example is a string or a number?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably not but I fixed it so they are ints

@UziTech UziTech requested a review from joshbruce April 12, 2019 20:48
@joshbruce joshbruce merged commit 9a6ca19 into markedjs:master Apr 13, 2019
@UziTech UziTech deleted the gfm-0.29 branch April 25, 2019 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants