Skip to content

Nested blockquotes #1464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 3, 2019
Merged

Nested blockquotes #1464

merged 4 commits into from
May 3, 2019

Conversation

@UziTech
Copy link
Member

@UziTech UziTech commented Apr 9, 2019 •
edited by joshbruce
Loading

Marked version: master

Markdown flavor: All

Description

Removes recursion for nested blockquotes

Fixes #1462 demo

TODO:

  • clean up code
  • add more tests

Contributor

  • Test(s) exist to ensure functionality and minimize regression

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@UziTech UziTech mentioned this pull request Apr 9, 2019
Closed
@UziTech UziTech changed the title [WIP] Nested blockquotes Nested blockquotes Apr 12, 2019
@styfle
Copy link
Member

styfle commented Apr 18, 2019

@UziTech Are these todo's still relevant?

  • clean up code
  • add more tests

@UziTech
Copy link
Member Author

UziTech commented Apr 18, 2019

Sorry no, I forgot to check them.

@styfle styfle added category: blockquotes L0 - security A security vulnerability within the Marked library is discovered labels Apr 18, 2019
@UziTech UziTech closed this Apr 25, 2019
@UziTech UziTech deleted the nested-blockquotes branch April 25, 2019 05:11
@UziTech UziTech restored the nested-blockquotes branch May 3, 2019 19:54
@UziTech UziTech reopened this May 3, 2019
@UziTech
Copy link
Member Author

UziTech commented May 3, 2019

I'm not sure why I closed this before. This should be ready to merge.

/cc @styfle @joshbruce @davisjam

@joshbruce joshbruce merged commit 67b91cf into markedjs:master May 3, 2019
@andersk andersk mentioned this pull request May 3, 2019
Closed
This was referenced Jun 4, 2019
Closed
Merged
joshbruce added a commit that referenced this pull request Jun 12, 2019
@joshbruce
Merge pull request #1497 from UziTech/revert-1464
5ba9ba5 
revert #1464
@UziTech UziTech deleted the nested-blockquotes branch July 1, 2019 18:08
@snyk-bot snyk-bot mentioned this pull request Aug 19, 2019
Open
This was referenced Aug 30, 2019
Open
Open
@snyk-bot snyk-bot mentioned this pull request Sep 24, 2019
Open
@yogansnykgit yogansnykgit mentioned this pull request Oct 25, 2024
Open
@Saranjoker Saranjoker mentioned this pull request Oct 26, 2024
Open
@shad0w92 shad0w92 mentioned this pull request Oct 26, 2024
Open
@shyamaaron shyamaaron mentioned this pull request Oct 26, 2024
Open
@Gowtham3223108 Gowtham3223108 mentioned this pull request Oct 26, 2024
Open
@udayreddy026 udayreddy026 mentioned this pull request Oct 26, 2024
Open
@moamed-syed moamed-syed mentioned this pull request Oct 27, 2024
Open
@ManPrivate ManPrivate mentioned this pull request Oct 27, 2024
Closed
@tdsnyk tdsnyk mentioned this pull request Oct 28, 2024
Open
@sri-sankari sri-sankari mentioned this pull request Oct 28, 2024
Open
@mohankumar931 mohankumar931 mentioned this pull request Oct 28, 2024
Open
@sound25 sound25 mentioned this pull request Oct 29, 2024
Open
@Latha-lgtm Latha-lgtm mentioned this pull request Oct 29, 2024
Open
@GOWTHAMAKURINJIVEANDAN GOWTHAMAKURINJIVEANDAN mentioned this pull request Oct 29, 2024
Open
@Dejah2024 Dejah2024 mentioned this pull request Oct 30, 2024
Open
@ThiruVaithiya ThiruVaithiya mentioned this pull request Oct 30, 2024
Open
@Suriya0802 Suriya0802 mentioned this pull request Oct 30, 2024
Open
@Shriv12 Shriv12 mentioned this pull request Oct 30, 2024
Open
@Magali0007 Magali0007 mentioned this pull request Oct 31, 2024
Open
@Ganesh13349 Ganesh13349 mentioned this pull request Oct 31, 2024
Open
@sinnakkrishnan sinnakkrishnan mentioned this pull request Nov 1, 2024
Open
@krithika-manohar krithika-manohar mentioned this pull request Nov 1, 2024
Open
@SAGAYANELSON55 SAGAYANELSON55 mentioned this pull request Nov 1, 2024
Open
@swathi-ra swathi-ra mentioned this pull request Nov 2, 2024
Open
@HUGO-AppSec HUGO-AppSec mentioned this pull request Nov 3, 2024
Open
@danielsb74 danielsb74 mentioned this pull request Nov 5, 2024
Open
@selvaganesh26 selvaganesh26 mentioned this pull request Nov 5, 2024
Open
@merkeldev merkeldev mentioned this pull request Nov 5, 2024
Open
@joedean-git joedean-git mentioned this pull request Nov 9, 2024
Open
@BenDrKo BenDrKo mentioned this pull request Nov 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@styfle styfle styfle approved these changes

@joshbruce joshbruce joshbruce approved these changes

@davisjam davisjam Awaiting requested review from davisjam

Assignees

No one assigned

Labels

category: blockquotes L0 - security A security vulnerability within the Marked library is discovered

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

marked(">".repeat(5000)) crashes with recursion error

3 participants

@UziTech @styfle @joshbruce