Rails 4.2 #655
Rails 4.2 #655
Conversation
The Rails 4.2 dummy app is not backwards compatible anymore. Rails and Semver \o/
Rails 4.2 complains about params having mixed stringified and symbolized keys.
Conflicts: app/controllers/alchemy/contents_controller.rb spec/libraries/resource_spec.rb
|
Rails 4.2 was released on Dec 19th, any news on this? |
Conflicts: app/controllers/alchemy/pages_controller.rb
To hvae respond_to and respond_with back.
The JSON api moved into it's own namespace.
|
The tests are passing now. But we have a lots of deprecations I would like to address before we merge this. @gabrielrios please test the gem 'alchemy_cms', github: 'AlchemyCMS/alchemy_cms', branch: 'rails-4.2'And run Thanks and merry Christmas 🎄 |
|
Hey there - we're in the process of evaluating alchemy to integrate with a new app we've got at work. Just wondering where this PR fits in terms of priority as it'd be nice to drop a stable version into our 4.2 app. |
|
Our first priority is to release 3.1 (currently in rc1). Then we concentrate on Rails 4.2 for a 3.2 release. Please try the rails-4.2 branch in your app and report any Feedback. I will merge the master into that in a minute. So besides any Rails 4.2 related stuff this can be considered stable. That would be very helpful to get the 3.2 release soon. Thanks |
Conflicts: .travis.yml alchemy_cms.gemspec spec/dummy/config/application.rb spec/dummy/config/environments/test.rb
Ruby 1.9 is deprecated and support ends in mid 2015. There is **no reason** to not use Ruby 2.x
|
@joho I updated the branch, tests all pass \o/ It would be nice if you could test this in your Rails 4.2 app: gem 'alchemy_cms', github: 'AlchemyCMS/alchemy_cms', branch: 'rails-4.2'and report any regressions here. |
Default Rails 4.2 apps depend on sass-rails 5.0
|
There are some problems with the backend interface after the update:
Tags inside the editor popup in the picture library: |
|
Yes. Encountered these as well. I guess this is an sass issue after upgrading to |
We need to require it in the manifest file, since the sass file is imported via sass import statement what's not working anymore for sass-rails 5.0. Also see: jquery-ui-rails/jquery-ui-rails#89 (comment)
|
@afdev82 this should be fixed now. Could you please try again with current |
|
Thanks, this fixes the problems above. |
|
I found one issue: the line at |
Conflicts: Gemfile
|
@vmoravec fixed the rails version. Thanks for reporting 👍 |
6 participants
This pull request shall only be merged after rails 4.2 was released and rails/rails#17453 gets solved. I just opened it so we can run tests on travis.
This branch will be regularly updated and finally merged into master after Rails 4.2 got released.