Skip to content

Commit 27c3036

Browse files
EdgeJschallert
andauthored
Add the coldWritesEnabled option to Namespace options (#233)
Co-authored-by: Matt Schallert <[email protected]>
1 parent 8edea4b commit 27c3036

File tree

7 files changed

+10
-3
lines changed

7 files changed

+10
-3
lines changed

docs/api.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -181,6 +181,7 @@ NamespaceOptions defines parameters for an M3DB namespace. See https://m3db.gith
181181
| snapshotEnabled | SnapshotEnabled controls whether snapshotting is enabled. | bool | false |
182182
| retentionOptions | RetentionOptions sets the retention parameters. | [RetentionOptions](#retentionoptions) | false |
183183
| indexOptions | IndexOptions sets the indexing parameters. | [IndexOptions](#indexoptions) | false |
184+
| coldWritesEnabled | ColdWritesEnabled controls whether cold writes are enabled. | bool | false |
184185

185186
[Back to TOC](#table-of-contents)
186187

pkg/apis/m3dboperator/v1alpha1/namespace.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,4 +90,7 @@ type NamespaceOptions struct {
9090

9191
// IndexOptions sets the indexing parameters.
9292
IndexOptions IndexOptions `json:"indexOptions,omitempty"`
93+
94+
// ColdWritesEnabled controls whether cold writes are enabled.
95+
ColdWritesEnabled bool `json:"coldWritesEnabled,omitempty"`
9396
}

pkg/controller/add_cluster_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,10 @@ import (
2727

2828
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2929

30-
"k8s.io/utils/pointer"
3130
"github.com/rakyll/statik/fs"
3231
"github.com/stretchr/testify/assert"
3332
"github.com/stretchr/testify/require"
33+
"k8s.io/utils/pointer"
3434
)
3535

3636
func registerValidConfigMap(content string) error {

pkg/controller/update_cluster_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ import (
3131

3232
myspec "github.com/m3db/m3db-operator/pkg/apis/m3dboperator/v1alpha1"
3333
crdfake "github.com/m3db/m3db-operator/pkg/client/clientset/versioned/fake"
34-
"github.com/m3db/m3db-operator/pkg/k8sops/m3db"
3534
"github.com/m3db/m3db-operator/pkg/k8sops/labels"
35+
"github.com/m3db/m3db-operator/pkg/k8sops/m3db"
3636
"github.com/m3db/m3db-operator/pkg/k8sops/podidentity"
3737
"github.com/m3db/m3db-operator/pkg/m3admin"
3838

pkg/k8sops/m3db/config_map_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@ import (
2828

2929
corev1 "k8s.io/api/core/v1"
3030

31-
"k8s.io/utils/pointer"
3231
"github.com/rakyll/statik/fs"
3332
"github.com/stretchr/testify/assert"
3433
"github.com/stretchr/testify/require"
34+
"k8s.io/utils/pointer"
3535
)
3636

3737
func registerValidConfigMap() error {

pkg/m3admin/namespace/namespace.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,7 @@ func m3dbNamespaceOptsFromSpec(opts *myspec.NamespaceOptions) (*m3ns.NamespaceOp
9999
RetentionOptions: retentionOpts,
100100
SnapshotEnabled: opts.SnapshotEnabled,
101101
IndexOptions: indexOpts,
102+
ColdWritesEnabled: opts.ColdWritesEnabled,
102103
}, nil
103104
}
104105

pkg/m3admin/namespace/presets.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ var (
6161
Enabled: true,
6262
BlockSize: (2 * time.Hour).String(),
6363
},
64+
ColdWritesEnabled: false,
6465
}
6566

6667
presetOneMinuteFourtyDaysIndexed = myspec.NamespaceOptions{
@@ -82,5 +83,6 @@ var (
8283
Enabled: true,
8384
BlockSize: (24 * time.Hour).String(),
8485
},
86+
ColdWritesEnabled: false,
8587
}
8688
)

0 commit comments

Comments
 (0)