Changed the FL parser mechanism from download-binary to download-source

Author: LeStahL

.appveyor.yml

@@ -17,15 +17,12 @@ install:
         Invoke-WebRequest "https://web.archive.org/web/20200502121517/https://www.steinberg.net/sdk_downloads/vstsdk366_27_06_2016_build_61.zip" -OutFile "vstsdk.zip"
         Expand-Archive "vstsdk.zip" "C:\tmp"
       }
-      if (-Not (Test-Path "C:\tmp\Monad.FLParser.dll")) {
-        Invoke-WebRequest "https://github.com/LeStahL/FLParser/releases/download/compatibility-20.9/Monad.FLParser.dll" -OutFile "C:\tmp\Monad.FLParser.dll"
-      }
 
 build_script:
   # build native code/tests
   - mkdir build
   - cd build
-  - cmake -DCMAKE_GENERATOR_PLATFORM=%PLATFORM% -DVSTSDK3_DIR="C:/tmp/VST3 SDK" -DMONAD_FL_PARSER_DIR="C:/tmp/" ..
+  - cmake -DCMAKE_GENERATOR_PLATFORM=%PLATFORM% -DVSTSDK3_DIR="C:/tmp/VST3 SDK" -DDOWNLOAD_MONAD_FL_PARSER=ON -DMONAD_FL_PARSER_DIR="C:/tmp/Monad.FLParser" ..
   - msbuild /v:minimal /nologo WaveSabre.sln
   - msbuild /v:minimal /nologo /property:Configuration="MinSizeRel" WaveSabre.sln
   - cd ..

.gitignore

@@ -35,7 +35,6 @@ Vst3.x/*
 !Vst3.x/README
 Data/data.aps
 Vsts/*/*.def
-WaveSabreConvert/FLParser/Monad.FLParser.dll
 
 # Ignore VS 2017 IDE fluff
 .vs/

CMakeLists.txt

@@ -5,6 +5,9 @@ cmake_policy(SET CMP0057 NEW)
 include(CSharpUtilities)
 set(CMAKE_CSharp_FLAGS ${CMAKE_CSharp_FLAGS} "/langversion:6")
 
+find_package(Git REQUIRED)
+include(ExternalProject)
+
 cmake_minimum_required(VERSION 3.11)
 set_property(GLOBAL PROPERTY USE_FOLDERS ON)
 
@@ -19,7 +22,7 @@ set(BUILD_WAVESABRE_CONVERT_TESTS ON CACHE BOOL "Do not build the WaveSabreConve
 set(BUILD_CONVERT_THE_FUCK ON CACHE BOOL "Do not build ConvertTheFuck.")
 set(BUILD_PROJECT_MANAGER ON CACHE BOOL "Do not build the project manager.")
 set(VSTSDK3_DIR "${PROJECT_SOURCE_DIR}/Vst3.x/" CACHE PATH "VSTSDK location.")
-set(MONAD_FL_PARSER_DIR "${PROJECT_SOURCE_DIR}/WaveSabreConvert/FLParser/" CACHE PATH "Monad FL parser location.")
+set(MONAD_FL_PARSER_DIR "${CMAKE_CURRENT_BINARY_DIR}/Monad.FLParser.Source" CACHE PATH "Monad FL parser location.")
 
 # Download and unpack VST3 SDK
 set(DOWNLOAD_VST3SDK OFF CACHE BOOL "Download and unpack VST3 SDK automatically.")
@@ -37,12 +40,23 @@ endif()
 # Download and unpack the Monad FL Parser
 set(DOWNLOAD_MONAD_FL_PARSER OFF CACHE BOOL "Download the Monad FL parser binary automatically.")
 if(${BUILD_WAVESABRE_CONVERT} AND ${DOWNLOAD_MONAD_FL_PARSER})
-	find_file(MONAD_FL_PARSER_TEST name Monad.FLParser.dll HINTS ${MONAD_FL_PARSER_DIR})
+	set(MONAD_FL_PARSER_BINARY ${CMAKE_CURRENT_BINARY_DIR}/Monad.FLParser/Release/Monad.FLParser.dll)
+	find_file(MONAD_FL_PARSER_TEST NAME Project.cs HINTS ${MONAD_FL_PARSER_DIR})
 	if(${MONAD_FL_PARSER_TEST} MATCHES MONAD_FL_PARSER_TEST-NOTFOUND)
 		message(STATUS "Monad FL parser not found. Will download.")
-		file(DOWNLOAD https://github.com/LeStahL/FLParser/releases/download/compatibility-20.9/Monad.FLParser.dll Monad.FLParser.dll SHOW_PROGRESS)
-		file(COPY "${CMAKE_CURRENT_BINARY_DIR}/Monad.FLParser.dll" DESTINATION "${MONAD_FL_PARSER_DIR}")
+		ExternalProject_Add(FLParser
+			SOURCE_DIR ${MONAD_FL_PARSER_DIR}
+			BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR}/Monad.FLParser
+			GIT_REPOSITORY https://github.com/Kwarf/FLParser.git
+			CONFIGURE_COMMAND ${CMAKE_COMMAND} -E copy ${PROJECT_SOURCE_DIR}/WaveSabreConvert/FLParser/CMakeLists.txt ${MONAD_FL_PARSER_DIR}/CMakeLists.txt && ${CMAKE_COMMAND} ${MONAD_FL_PARSER_DIR} -DMONAD_FL_PARSER_DIR=${MONAD_FL_PARSER_DIR}
+			BUILD_COMMAND ${CMAKE_COMMAND} --build ${CMAKE_CURRENT_BINARY_DIR}/Monad.FLParser --config Release -- -m
+			INSTALL_COMMAND ""
+		)
 	endif()
+elseif(${BUILD_WAVESABRE_CONVERT})
+	message(STATUS "Using existent FL parser repo.")
+	add_subdirectory(WaveSabreConvert/FLParser)
+	set(MONAD_FL_PARSER_BINARY ${CMAKE_CURRENT_BINARY_DIR}/WaveSabreConvert/FLParser/Release/Monad.FLParser.dll)
 endif()
 
 # shared code

Docs/Home.md

@@ -4,7 +4,7 @@
 
 - WaveSabre builds have only been tested with Visual Studio 2013/2015/2017/2019 and version 3.6.6 of the VST3 SDK.
 - Due to licensing requirements, WaveSabre requires you to either [download](https://web.archive.org/web/20200502121517/https://www.steinberg.net/sdk_downloads/vstsdk366_27_06_2016_build_61.zip) and copy the VST3 SDK into the build yourself. Download, extract, and copy into the *"Vst3.x"* folder. See [this readme](https://github.com/logicomacorp/WaveSabre/blob/master/Vst3.x/README) or download the VST3 SDK automatically using CMake (see below).
-- For the same reasons, you should [download](https://github.com/LeStahL/FLParser/releases/download/compatibility-20.9/Monad.FLParser.dll) and copy the Monad FL parser into the build yourself. Download and copy the dll into the folder at `WaveSabreConvert/FLParser/`. See [this readme](https://github.com/logicomacorp/WaveSabre/blob/master/WaveSabreConvert/FLParser/README). You can also let CMake download the Monad FL parser automatically for you; see below for the command line options to use for this.
+- For the same reasons, you should [download](https://github.com/Kwarf/FLParser) the Monad FL parser source yourself. You can also let CMake download the Monad FL parser automatically for you; see below for the command line options to use for this.
 
 ### CMake
 

WaveSabreConvert/CMakeLists.txt

@@ -31,10 +31,15 @@ set(WAVESABRE_CONVERT_SOURCES
 )
 
 add_library(WaveSabreConvert SHARED ${WAVESABRE_CONVERT_SOURCES})
+set_property(TARGET WaveSabreConvert PROPERTY VS_DOTNET_REFERENCE_Monad.FLParser "${MONAD_FL_PARSER_BINARY}")
+if(${DOWNLOAD_MONAD_FL_PARSER})
+	add_dependencies(WaveSabreConvert FLParser)
+else()
+	add_dependencies(WaveSabreConvert Monad.FLParser)
+endif()
 
 csharp_set_designer_cs_properties(${WAVESABRE_CONVERT_SOURCES})
 csharp_set_windows_forms_properties(${WAVESABRE_CONVERT_SOURCES})
-set_property(TARGET WaveSabreConvert PROPERTY VS_DOTNET_REFERENCE_Monad.FLParser "${MONAD_FL_PARSER_DIR}/Monad.FLParser.dll")
 set_property(TARGET WaveSabreConvert PROPERTY VS_DOTNET_TARGET_FRAMEWORK_VERSION "v4.6.1")
 set_property(TARGET WaveSabreConvert PROPERTY VS_DOTNET_REFERENCES 
 	"System"

WaveSabreConvert/FLParser/CMakeLists.txt

@@ -0,0 +1,38 @@
+cmake_minimum_required(VERSION 3.11)
+
+project(Monad.FLParser LANGUAGES CSharp)
+
+cmake_policy(SET CMP0057 NEW)
+include(CSharpUtilities)
+set(CMAKE_CSharp_FLAGS ${CMAKE_CSharp_FLAGS} "/langversion:6")
+
+set(MONAD_FL_PARSER_SOURCES
+	${MONAD_FL_PARSER_DIR}/Properties/AssemblyInfo.cs
+
+	${MONAD_FL_PARSER_DIR}/AutomationData.cs
+	${MONAD_FL_PARSER_DIR}/AutomationKeyframe.cs
+	${MONAD_FL_PARSER_DIR}/Channel.cs
+	${MONAD_FL_PARSER_DIR}/ChannelPlaylistItem.cs
+	${MONAD_FL_PARSER_DIR}/Enums.cs
+	${MONAD_FL_PARSER_DIR}/FlParseException.cs
+	${MONAD_FL_PARSER_DIR}/GeneratorData.cs
+	${MONAD_FL_PARSER_DIR}/IChannelData.cs
+	${MONAD_FL_PARSER_DIR}/Insert.cs
+	${MONAD_FL_PARSER_DIR}/InsertSlot.cs
+	${MONAD_FL_PARSER_DIR}/IPlaylistItem.cs
+	${MONAD_FL_PARSER_DIR}/Note.cs
+	${MONAD_FL_PARSER_DIR}/Pattern.cs
+	${MONAD_FL_PARSER_DIR}/PatternPlaylistItem.cs
+	${MONAD_FL_PARSER_DIR}/Plugin.cs
+	${MONAD_FL_PARSER_DIR}/PluginIoInfo.cs
+	${MONAD_FL_PARSER_DIR}/Project.cs
+	${MONAD_FL_PARSER_DIR}/ProjectParser.cs
+	${MONAD_FL_PARSER_DIR}/Track.cs
+)
+
+add_library(Monad.FLParser SHARED ${MONAD_FL_PARSER_SOURCES})
+set_property(TARGET Monad.FLParser PROPERTY VS_DOTNET_TARGET_FRAMEWORK_VERSION "v4.6.1")
+set_property(TARGET Monad.FLParser PROPERTY VS_DOTNET_REFERENCES 
+	"System"
+	"System.Core"
+)