From 872765d6f4ac281f9fd8f679dee1a1703b1cf7ce Mon Sep 17 00:00:00 2001 From: "Mikhail R. Gadelha" Date: Fri, 15 Sep 2023 22:02:37 -0300 Subject: [PATCH 1/2] [libc] Add ${CMAKE_CROSSCOMPILING_EMULATOR} to custom test cmdlines ${CMAKE_CROSSCOMPILING_EMULATOR} will be used in the new rv32 buildbot and is preppended automatically when we call add_custom_target in CMake, except when we use a custom command. There are two places where custom commands are used in libc, so we explicitly add the ${CMAKE_CROSSCOMPILING_EMULATOR} variable there. Other systems that don't use ${CMAKE_CROSSCOMPILING_EMULATOR} are unaffected --- libc/cmake/modules/LLVMLibCTestRules.cmake | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libc/cmake/modules/LLVMLibCTestRules.cmake b/libc/cmake/modules/LLVMLibCTestRules.cmake index e1286b4ab9631..552cbd739628d 100644 --- a/libc/cmake/modules/LLVMLibCTestRules.cmake +++ b/libc/cmake/modules/LLVMLibCTestRules.cmake @@ -561,7 +561,7 @@ function(add_integration_test test_name) # to expand the list (by including the option COMMAND_EXPAND_LISTS). This # makes `add_custom_target` construct the correct command and execute it. set(test_cmd - ${INTEGRATION_TEST_ENV} + ${CMAKE_CROSSCOMPILING_EMULATOR} ${INTEGRATION_TEST_ENV} $<$:${gpu_loader_exe}> ${INTEGRATION_TEST_LOADER_ARGS} $ ${INTEGRATION_TEST_ARGS}) @@ -728,7 +728,7 @@ function(add_libc_hermetic_test test_name) set(test_cmd ${HERMETIC_TEST_ENV} $<$:${gpu_loader_exe}> ${HERMETIC_TEST_LOADER_ARGS} - $ ${HERMETIC_TEST_ARGS}) + ${CMAKE_CROSSCOMPILING_EMULATOR} $ ${HERMETIC_TEST_ARGS}) add_custom_target( ${fq_target_name} COMMAND ${test_cmd} From 64b0e3c763c3e640186d3a723916d8e95cf5f633 Mon Sep 17 00:00:00 2001 From: "Mikhail R. Gadelha" Date: Fri, 15 Sep 2023 22:02:37 -0300 Subject: [PATCH 2/2] Put CMAKE_CROSSCOMPILING_EMULATOR right after the gpu_loader_exe --- libc/cmake/modules/LLVMLibCTestRules.cmake | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libc/cmake/modules/LLVMLibCTestRules.cmake b/libc/cmake/modules/LLVMLibCTestRules.cmake index 552cbd739628d..b6bd0ba60a74c 100644 --- a/libc/cmake/modules/LLVMLibCTestRules.cmake +++ b/libc/cmake/modules/LLVMLibCTestRules.cmake @@ -561,8 +561,9 @@ function(add_integration_test test_name) # to expand the list (by including the option COMMAND_EXPAND_LISTS). This # makes `add_custom_target` construct the correct command and execute it. set(test_cmd - ${CMAKE_CROSSCOMPILING_EMULATOR} ${INTEGRATION_TEST_ENV} + ${INTEGRATION_TEST_ENV} $<$:${gpu_loader_exe}> + ${CMAKE_CROSSCOMPILING_EMULATOR} ${INTEGRATION_TEST_LOADER_ARGS} $ ${INTEGRATION_TEST_ARGS}) add_custom_target( @@ -727,8 +728,8 @@ function(add_libc_hermetic_test test_name) endif() set(test_cmd ${HERMETIC_TEST_ENV} - $<$:${gpu_loader_exe}> ${HERMETIC_TEST_LOADER_ARGS} - ${CMAKE_CROSSCOMPILING_EMULATOR} $ ${HERMETIC_TEST_ARGS}) + $<$:${gpu_loader_exe}> ${CMAKE_CROSSCOMPILING_EMULATOR} ${HERMETIC_TEST_LOADER_ARGS} + $ ${HERMETIC_TEST_ARGS}) add_custom_target( ${fq_target_name} COMMAND ${test_cmd}