Skip to content

Commit c97ca8b

Browse files
committed
[x86] Synchronize fp128 and i128 ABI tests (nfc)
The ABI tests for fp128 covers a handful of things that the i128 test currently does not, including targets other than x86-64 Linux and some simpler argument cases. Update the i128 test to be consistent with fp128. All existing test function patterns still exist, though they all wind up renamed. Additionally correct some `call` signatures in the fp128 test (not relevant for output).
1 parent 58e38b8 commit c97ca8b

File tree

2 files changed

+648
-83
lines changed

2 files changed

+648
-83
lines changed

llvm/test/CodeGen/X86/fp128-abi.ll

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
22

3+
; Consider keeping tests in sync with i128-abi.ll
4+
35
; RUN: llc < %s -mtriple=x86_64-unknown-linux-gnu -verify-machineinstrs | FileCheck %s --check-prefix=CHECK-X64
46
; RUN: llc < %s -mtriple=i686-unknown-linux-gnu -verify-machineinstrs | FileCheck %s --check-prefix=CHECK-X86
57
; RUN: llc < %s -mtriple=x86_64-pc-windows-msvc -verify-machineinstrs | FileCheck %s --check-prefix=CHECK-MSVC64
@@ -360,7 +362,7 @@ define void @call_first_arg(fp128 %x) nounwind {
360362
; CHECK-MINGW-NEXT: callq first_arg
361363
; CHECK-MINGW-NEXT: addq $56, %rsp
362364
; CHECK-MINGW-NEXT: retq
363-
call i128 @first_arg(fp128 %x)
365+
call fp128 @first_arg(fp128 %x)
364366
ret void
365367
}
366368

@@ -452,7 +454,7 @@ define void @call_leading_args(fp128 %x) nounwind {
452454
; CHECK-MINGW-NEXT: callq leading_args
453455
; CHECK-MINGW-NEXT: addq $72, %rsp
454456
; CHECK-MINGW-NEXT: retq
455-
call i128 @leading_args(i64 0, i64 0, i64 0, i64 0, fp128 %x)
457+
call fp128 @leading_args(i64 0, i64 0, i64 0, i64 0, fp128 %x)
456458
ret void
457459
}
458460

@@ -562,7 +564,7 @@ define void @call_many_leading_args(fp128 %x) nounwind {
562564
; CHECK-MINGW-NEXT: callq many_leading_args
563565
; CHECK-MINGW-NEXT: addq $88, %rsp
564566
; CHECK-MINGW-NEXT: retq
565-
call i128 @many_leading_args(i64 0, i64 0, i64 0, i64 0, fp128 0xL0, fp128 %x)
567+
call fp128 @many_leading_args(i64 0, i64 0, i64 0, i64 0, fp128 0xL0, fp128 %x)
566568
ret void
567569
}
568570

@@ -654,6 +656,6 @@ define void @call_trailing_arg(fp128 %x) nounwind {
654656
; CHECK-MINGW-NEXT: callq trailing_arg
655657
; CHECK-MINGW-NEXT: addq $72, %rsp
656658
; CHECK-MINGW-NEXT: retq
657-
call i128 @trailing_arg(i64 0, i64 0, i64 0, i64 0, fp128 %x)
659+
call fp128 @trailing_arg(i64 0, i64 0, i64 0, i64 0, fp128 %x)
658660
ret void
659661
}

0 commit comments

Comments
 (0)