Skip to content

Commit e4f67f2

Browse files
hakzsamMarge Bot
authored andcommitted
radv: do not expose NV DGC extensions on GFX6-7
These extensions were experimental and only exposed with radv_dgc=true for vkd3d-proton. Only two games require DGC (Starfield and Halo Infinite) and both also require sparse support which GFX6-7 can't support. GFX6-7 support is also mostly broken because IB2 can't be used when indirect draw packets are used and RADV uses that to preprocess IBO. Also with the EXT, indirect draws are more common and can't be supported. Everything could work with a bunch of time and workarounds but I don't think it's worth the effort given there is no real use. Cc: mesa-stable Signed-off-by: Samuel Pitoiset <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31491>
1 parent 065b45e commit e4f67f2

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/amd/vulkan/radv_physical_device.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -747,8 +747,8 @@ radv_physical_device_get_supported_extensions(const struct radv_physical_device
747747
.INTEL_shader_integer_functions2 = true,
748748
.MESA_image_alignment_control = pdev->info.gfx_level >= GFX9 && pdev->info.gfx_level <= GFX11_5,
749749
.NV_compute_shader_derivatives = true,
750-
.NV_device_generated_commands = instance->drirc.enable_dgc,
751-
.NV_device_generated_commands_compute = instance->drirc.enable_dgc,
750+
.NV_device_generated_commands = pdev->info.gfx_level >= GFX8 && instance->drirc.enable_dgc,
751+
.NV_device_generated_commands_compute = pdev->info.gfx_level >= GFX8 && instance->drirc.enable_dgc,
752752
/* Undocumented extension purely for vkd3d-proton. This check is to prevent anyone else from
753753
* using it.
754754
*/

src/util/driconf.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -694,7 +694,7 @@
694694

695695
#define DRI_CONF_RADV_DGC(def) \
696696
DRI_CONF_OPT_B(radv_dgc, def, \
697-
"Expose an experimental implementation of VK_NV_device_generated_commands")
697+
"Expose an experimental implementation of VK_NV_device_generated_commands on GFX8+")
698698

699699
#define DRI_CONF_RADV_FLUSH_BEFORE_QUERY_COPY(def) \
700700
DRI_CONF_OPT_B( \

0 commit comments

Comments
 (0)