fixes in-place modification issue

Author: thoraxe

src/app/endpoints/query.py

@@ -50,23 +50,30 @@
 auth_dependency = get_auth_dependency()
 
 
-def _process_knowledge_search_content(
-    tool_response: Any, metadata_map: dict[str, dict[str, Any]]
-) -> None:
-    """Process knowledge search tool response content for metadata."""
+def _process_knowledge_search_content(tool_response: Any) -> dict[str, dict[str, Any]]:
+    """Process knowledge search tool response content for metadata.
+
+    Args:
+        tool_response: Tool response object containing content to parse
+
+    Returns:
+        Dictionary mapping document_id to metadata dict
+    """
+    metadata_map: dict[str, dict[str, Any]] = {}
+
     # Guard against missing tool_response or content
     if not tool_response:
-        return
+        return metadata_map
 
     content = getattr(tool_response, "content", None)
     if not content:
-        return
+        return metadata_map
 
     # Ensure content is iterable
     try:
         iter(content)
     except TypeError:
-        return
+        return metadata_map
 
     for text_content_item in content:
         # Skip items that lack a non-empty "text" attribute
@@ -83,6 +90,8 @@ def _process_knowledge_search_content(
                 text[:200] + "..." if len(text) > 200 else text,
             )
 
+    return metadata_map
+
 
 def extract_referenced_documents_from_steps(
     steps: list[Any],
@@ -109,7 +118,8 @@ def extract_referenced_documents_from_steps(
             ) != "knowledge_search" or not getattr(tool_response, "content", []):
                 continue
 
-            _process_knowledge_search_content(tool_response, metadata_map)
+            response_metadata = _process_knowledge_search_content(tool_response)
+            metadata_map.update(response_metadata)
 
     # Extract referenced documents from metadata with error handling
     referenced_documents = []

tests/unit/app/endpoints/test_query.py

@@ -1601,9 +1601,7 @@ def test_process_knowledge_search_content_with_valid_metadata(mocker):
     tool_response = mocker.Mock()
     tool_response.content = [text_content_item]
 
-    metadata_map = {}
-
-    _process_knowledge_search_content(tool_response, metadata_map)
+    metadata_map = _process_knowledge_search_content(tool_response)
 
     # Verify metadata was correctly parsed and added
     assert "doc-1" in metadata_map
@@ -1626,9 +1624,7 @@ def test_process_knowledge_search_content_with_invalid_metadata_syntax_error(moc
     tool_response = mocker.Mock()
     tool_response.content = [text_content_item]
 
-    metadata_map = {}
-
-    _process_knowledge_search_content(tool_response, metadata_map)
+    metadata_map = _process_knowledge_search_content(tool_response)
 
     # Verify metadata_map remains empty due to exception
     assert len(metadata_map) == 0
@@ -1653,9 +1649,7 @@ def test_process_knowledge_search_content_with_invalid_metadata_value_error(mock
     tool_response = mocker.Mock()
     tool_response.content = [text_content_item]
 
-    metadata_map = {}
-
-    _process_knowledge_search_content(tool_response, metadata_map)
+    metadata_map = _process_knowledge_search_content(tool_response)
 
     # Verify metadata_map remains empty due to exception
     assert len(metadata_map) == 0
@@ -1680,9 +1674,7 @@ def test_process_knowledge_search_content_with_non_dict_metadata(mocker):
     tool_response = mocker.Mock()
     tool_response.content = [text_content_item]
 
-    metadata_map = {}
-
-    _process_knowledge_search_content(tool_response, metadata_map)
+    metadata_map = _process_knowledge_search_content(tool_response)
 
     # Verify metadata_map remains empty (no document_id in string)
     assert len(metadata_map) == 0
@@ -1703,9 +1695,7 @@ def test_process_knowledge_search_content_with_metadata_missing_document_id(mock
     tool_response = mocker.Mock()
     tool_response.content = [text_content_item]
 
-    metadata_map = {}
-
-    _process_knowledge_search_content(tool_response, metadata_map)
+    metadata_map = _process_knowledge_search_content(tool_response)
 
     # Verify metadata_map remains empty since document_id is missing
     assert len(metadata_map) == 0
@@ -1719,9 +1709,7 @@ def test_process_knowledge_search_content_with_no_text_attribute(mocker):
     tool_response = mocker.Mock()
     tool_response.content = [text_content_item]
 
-    metadata_map = {}
-
-    _process_knowledge_search_content(tool_response, metadata_map)
+    metadata_map = _process_knowledge_search_content(tool_response)
 
     # Verify metadata_map remains empty since text attribute is missing
     assert len(metadata_map) == 0
@@ -1733,9 +1721,7 @@ def test_process_knowledge_search_content_with_none_content(mocker):
     tool_response = mocker.Mock()
     tool_response.content = None
 
-    metadata_map = {}
-
-    _process_knowledge_search_content(tool_response, metadata_map)
+    metadata_map = _process_knowledge_search_content(tool_response)
 
     # Verify metadata_map remains empty when content is None
     assert len(metadata_map) == 0