fix: radialGradient cache key was using linearGradient (#474)

wouterlucas · web-flow · commit 6174898354d2 · 2025-01-08T13:15:29.000Z
Causing issues where cached linearGradients is shared with
radialGradient
diff --git a/src/core/renderers/webgl/shaders/effects/RadialGradientEffect.ts b/src/core/renderers/webgl/shaders/effects/RadialGradientEffect.ts
@@ -64,12 +64,12 @@ export class RadialGradientEffect extends ShaderEffect {
 
   static override getEffectKey(props: RadialGradientEffectProps): string {
     if ((props.colors as unknown as ShaderEffectValueMap).value as number[]) {
-      return `linearGradient${
+      return `radialGradient${
         ((props.colors as unknown as ShaderEffectValueMap).value as number[])
           .length
       }`;
     }
-    return `linearGradient${props.colors!.length}`;
+    return `radialGradient${props.colors!.length}`;
   }
 
   static override resolveDefaults(

Original file line number	Diff line number	Diff line change
`@@ -64,12 +64,12 @@ export class RadialGradientEffect extends ShaderEffect {`
`64`	`64`
`65`	`65`	`static override getEffectKey(props: RadialGradientEffectProps): string {`
`66`	`66`	`if ((props.colors as unknown as ShaderEffectValueMap).value as number[]) {`
`67`		- return `linearGradient${
	`67`	+ return `radialGradient${
`68`	`68`	`((props.colors as unknown as ShaderEffectValueMap).value as number[])`
`69`	`69`	`.length`
`70`	`70`	}`;
`71`	`71`	`}`
`72`		- return `linearGradient${props.colors!.length}`;
	`72`	+ return `radialGradient${props.colors!.length}`;
`73`	`73`	`}`
`74`	`74`
`75`	`75`	`static override resolveDefaults(`