Skip to content

Commit 296a819

Browse files
authored
fix Docker build (#553)
We're a bit behind on pnpm versions and this causes issues with newer node installs and corepack. The issue is related to verifying the PNPM tarball signature, and it's failing because the signature in the TUF metadata cannot be validated—likely due to a key mismatch or expired/incomplete keyring used by Corepack: ``` Internal Error: Cannot find matching keyid: {"signatures":[{"sig":"MEUCIQDH6Kte1awtFvRUVsKWHtRaKuryH/0lm0Wswd29C+NdWAIgMxcudJ1cOlbnCh3oiFLkrQLua0vp6H+mGvycpY4TzxM=","keyid":"SHA256:DhQ8wR5APBvFHLF/+Tc+AYvPOdTpcIDqOhxsBHRwC7U"}],"keys":[{"expires":null,"keyid":"SHA256:jl3bwswu80PjjokCgh0o2w5c2U4LhQAE57gj9cz1kzA","keytype":"ecdsa-sha2-nistp256" ``` To work arround this I'm installing a pinned version of pnpm through corepack: ``` RUN corepack enable && corepack prepare [email protected] --activate ``` And removed the please use pnpm check script, its no longer needed. People can figure it out or they should read the readme.
2 parents 0d139f3 + 2175caf commit 296a819

File tree

3 files changed

+1
-15
lines changed

3 files changed

+1
-15
lines changed

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ COPY .npmrc .npmrc
99
COPY package.json package.json
1010

1111
# Install PNPM
12-
RUN corepack prepare && corepack enable
12+
RUN corepack enable && corepack prepare [email protected] --activate
1313

1414
# Get pnpm to install the version of Node declared in .npmrc
1515
RUN pnpm exec ls

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
"./inspector": "./dist/exports/inspector.js"
1515
},
1616
"scripts": {
17-
"preinstall": "node scripts/please-use-pnpm.js",
1817
"start": "cd examples && pnpm start",
1918
"start:prod": "cd examples && pnpm start:prod",
2019
"build": "tsc --build",

scripts/please-use-pnpm.js

Lines changed: 0 additions & 13 deletions
This file was deleted.

0 commit comments

Comments
 (0)