Merge pull request #55 from Vidalia/master

Added support for MSSQL databases

Author: justusdieckmann

classes/privacy/data_export_helper.php

@@ -157,11 +157,10 @@ protected static function export_all_posts_in_discussion($userid, \context $cont
               INNER JOIN {moodleoverflow_posts} p ON p.discussion = d.id
               LEFT JOIN {moodleoverflow_read} fr ON fr.postid = p.id AND fr.userid = :readuserid
               LEFT JOIN {moodleoverflow_ratings} rat ON rat.id = (
-                SELECT id FROM {moodleoverflow_ratings} ra
+                SELECT MAX(id) FROM {moodleoverflow_ratings} ra
                 WHERE ra.postid = p.id OR ra.userid = :ratinguserid
-                LIMIT 1
               )
-                   WHERE d.id = :discussionid
+                    WHERE d.id = :discussionid
         ";
         $params = [
             'discussionid' => $discussionid,

classes/ratings.php

@@ -140,9 +140,8 @@ public static function moodleoverflow_add_rating($moodleoverflow, $postid, $rati
             // Get other ratings in the discussion.
             $sql = "SELECT *
                     FROM {moodleoverflow_ratings}
-                    WHERE discussionid = $discussion->id AND rating = $rating
-                    LIMIT 1";
-            $otherrating = $DB->get_record_sql($sql);
+                    WHERE discussionid = ? AND rating = ?";
+            $otherrating = $DB->get_record_sql($sql, [ $discussion->id, $rating ]);
 
             // If there is an old rating, update it. Else create a new rating record.
             if ($otherrating) {
@@ -347,10 +346,9 @@ public static function moodleoverflow_user_rated($postid, $userid = null) {
         // Get the rating.
         $sql = "SELECT firstrated, rating
                   FROM {moodleoverflow_ratings}
-                 WHERE userid = $userid AND postid = $postid AND (rating = 1 OR rating = 2)
-                 LIMIT 1";
+                 WHERE userid = ? AND postid = ? AND (rating = 1 OR rating = 2)";
 
-        return ($DB->get_record_sql($sql));
+        return ($DB->get_record_sql($sql, [ $userid, $postid ]));
     }
 
     /**
@@ -390,9 +388,9 @@ public static function moodleoverflow_get_ratings_by_discussion($discussionid, $
                        (SELECT COUNT(rating) FROM {moodleoverflow_ratings} WHERE postid=p.id AND rating = 3) AS issolved,
                        (SELECT COUNT(rating) FROM {moodleoverflow_ratings} WHERE postid=p.id AND rating = 4) AS ishelpful
                   FROM {moodleoverflow_posts} p
-                 WHERE p.discussion = $discussionid
+                 WHERE p.discussion = ?
               GROUP BY p.id";
-        $votes = $DB->get_records_sql($sql);
+        $votes = $DB->get_records_sql($sql, [ $discussionid ]);
 
         // A single post is requested.
         if ($postid) {
@@ -596,9 +594,8 @@ private static function moodleoverflow_check_old_rating($postid, $userid, $oldra
         // Get the normal rating.
         $sql = "SELECT *
                 FROM {moodleoverflow_ratings}
-                WHERE userid = $userid AND postid = $postid AND (rating = 1 OR rating = 2)
-                LIMIT 1";
-        $rating['normal'] = $DB->get_record_sql($sql);
+                WHERE userid = ? AND postid = ? AND (rating = 1 OR rating = 2)";
+        $rating['normal'] = $DB->get_record_sql($sql, [ $userid, $postid ]);
 
         // Return the rating if it is requested.
         if ($oldrating == RATING_DOWNVOTE OR $oldrating == RATING_UPVOTE) {
@@ -608,9 +605,8 @@ private static function moodleoverflow_check_old_rating($postid, $userid, $oldra
         // Get the solved rating.
         $sql = "SELECT *
                 FROM {moodleoverflow_ratings}
-                WHERE userid = $userid AND postid = $postid AND rating = 3
-                LIMIT 1";
-        $rating['solved'] = $DB->get_record_sql($sql);
+                WHERE userid = ? AND postid = ? AND rating = 3";
+        $rating['solved'] = $DB->get_record_sql($sql, [ $userid, $postid ]);
 
         // Return the rating if it is requested.
         if ($oldrating == RATING_SOLVED) {
@@ -620,9 +616,8 @@ private static function moodleoverflow_check_old_rating($postid, $userid, $oldra
         // Get the helpful rating.
         $sql = "SELECT *
                 FROM {moodleoverflow_ratings}
-                WHERE userid = $userid AND postid = $postid AND rating = 4
-                LIMIT 1";
-        $rating['helpful'] = $DB->get_record_sql($sql);
+                WHERE userid = ? AND postid = ? AND rating = 4";
+        $rating['helpful'] = $DB->get_record_sql($sql, [ $userid, $postid ]);
 
         // Return the rating if it is requested.
         if ($oldrating == RATING_HELPFUL) {