-
Notifications
You must be signed in to change notification settings - Fork 0
fix: touch throttle #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Sources/LaunchDarklyObservability/UIInteractions/TouchIntepreter.swift
Outdated
Show resolved
Hide resolved
| guard duration >= TouchConstants.touchMoveThrottle else { | ||
| return | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Inconsistent Throttle Timing Post-Flush
After flushing touch points when track duration exceeds touchPathDuration, the throttle check is skipped for subsequent points because track.points is empty. The previous implementation used track.start as a fallback timestamp when no points existed, ensuring consistent throttling. Without this fallback, points immediately following a flush bypass time-based throttling and rely only on distance checks, potentially capturing points more frequently than touchMoveThrottle allows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want that more frequently
* main: fix: touch throttle (#81)
* main: fix: touch throttle (#81)
🤖 I have created a release *beep* *boop* --- ## [0.10.0](0.9.2...0.10.0) (2025-11-15) ### Features * ignore masking ([#80](#80)) ([1372064](1372064)) * options refactor ([#75](#75)) ([b442cbc](b442cbc)) * refactor instrumentation options ([#77](#77)) ([ebc2e24](ebc2e24)) ### Bug Fixes * touch throttle ([#81](#81)) ([6d1cd15](6d1cd15)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Bumps SDK to 0.10.0 and updates the changelog with new features and a bug fix. > > - **Release**: bump version to `0.10.0` > - Update `.` version in `.release-please-manifest.json` > - Update `sdkVersion` in `Sources/LaunchDarklyObservability/Version.swift` > - **Docs**: refresh `CHANGELOG.md` with features (ignore masking, options refactor, instrumentation options refactor) and a bug fix (touch throttle) > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 1bf72a3. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Note
Adjusts touch move throttling and long-path flushing to avoid dropping the last touch point; updates TestApp to production config.
TouchConstants: replacetouchMoveMaxDurationwithtouchMoveThrottleandtouchPathDurationinSources/LaunchDarklyObservability/UIInteractions/TouchIntepreter.swift..moved:touchPathwhen track duration exceedstouchPathDuration; append last point, emit.touchPath, reset track start/point, and continue.touchMoveThrottlebased on the last point timestamp.end/target.flushMovements(...): after emitting.touchPath, reset track start using the last point to retain continuity and prevent losing the last point.mobileKeyandserviceNameinTestApp/Sources/AppDelegate.swift; comment out staging config.Written by Cursor Bugbot for commit 7c767b7. This will update automatically on new commits. Configure here.