feat: ignore masking #80

abelonogov-ld · 2025-11-13T16:51:28Z

ldIgnore() method to turn off masking for a whole tree
fix issue when ldUnmask() could make view untappable in SwiftUI
fix unmaskAccessibilityIdentifiers

Note

Adds ldIgnore and explicit unmask controls (including Obj-C bridge), extends privacy options, and updates the mask collector to honor new ignore/unmask rules; demo app applies ldIgnore and updates identifiers.

API:
- Add ldIgnore() for SwiftUI and UIView, plus ldMask() convenience.
- Introduce Obj-C bridge ObjcLDMasking with maskView:, unmaskView:, ignoreView:.
- Update SessionReplayModifier to support optional isEnabled and isIgnored.
Privacy Options:
- Extend SessionReplayOptions.PrivacyOptions with unmaskUIViews, unmaskAccessibilityIdentifiers, and ignoreUIViews.
Masking Engine:
- MaskCollector.Settings now tracks maskUIViews, unmaskUIViews, ignoreUIViews, and corresponding accessibility identifiers.
- Add shouldIgnore and update shouldMask to respect explicit unmask/ignore via associated objects, class lists, and accessibility identifiers.
- Skip ignored views during collection and fall back to associated shouldMaskUIView when applicable.
Demo App:
- Apply .ldIgnore() to smoothie list rows; add "10" to masked accessibility identifiers.

^{Written by Cursor Bugbot for commit c6c149d. This will update automatically on new commits. Configure here.}

* main: chore: prepare folders for binaryframework (#79) refactor: get sampling config graphql to poso (#78) feat: refactor instrumentation options (#77) feat: options refactor (#75)

Sources/LaunchDarklySessionReplay/API/SessionReplayModifier.swift

Sources/LaunchDarklySessionReplay/ScreenCapture/MaskCollector.swift

mario-launchdarkly · 2025-11-13T23:06:18Z

Sources/LaunchDarklySessionReplay/ScreenCapture/MaskCollector.swift

-
+
+        func shouldIgnore(_ view: UIView) -> Bool {
+            let viewType = type(of: view)


this is a little bit expensive cpu-wise, just a notice, since you are now relying on ObjectIdentifier as the main approach to identify the views, it is not a good idea to change the approch this time.

I use ObjectIdentifier from the type not from the instance. That's why I need viewType

I understand, just a small notice, not asking for a change, we are good

Sources/LaunchDarklySessionReplay/ScreenCapture/MaskCollector.swift

mario-launchdarkly · 2025-11-13T23:10:40Z

Sources/LaunchDarklySessionReplay/ScreenCapture/MaskCollector.swift

                return true
            }

+            if SessionReplayAssociatedObjects.shouldMaskUIView(view) ?? false {


return SessionReplayAssociatedObjects.shouldMaskUIView(view) == true

mario-launchdarkly · 2025-11-13T23:12:03Z

Sources/LaunchDarklySessionReplay/ScreenCapture/MaskCollector.swift

            let effectiveFrame = rPresenation.convert(layer.frame, from: layer.superlayer)
+
+            let shouldIgnore = settings.shouldIgnore(view)
+            guard !shouldIgnore else { return }


better, if you don't need the result from settings.shouldIgnore(view) down below
guard !settings.shouldIgnore(view) else { return }

mario-launchdarkly · 2025-11-13T23:13:56Z

Sources/LaunchDarklySessionReplay/ScreenCapture/MaskCollector.swift

-//            let corner0 = CGPoint.zero
-//            let corner1 = CGPoint(x: lBounds.width, y: 0)
-
+            //            let corner0 = CGPoint.zero


delete commented-out code

* main: fix: touch throttle (#81)

…-launchdarkly-observability into andrey/ignore-masking * 'andrey/ignore-masking' of github.com:launchdarkly/swift-launchdarkly-observability:

Sources/LaunchDarklySessionReplay/ScreenCapture/MaskCollector.swift

mario-launchdarkly · 2025-11-14T14:22:03Z

Sources/LaunchDarklySessionReplay/API/ObjcLDMasking.swift

+@objcMembers
+public class ObjcLDMasking: NSObject {
+    // Use explicit selectors so we control the Obj-C names.
+    @objc(maskView:)


if you are using @objcMembers annotation this is redundant, remove it please

I already but it also not as it assigns the name exported method

mario-launchdarkly · 2025-11-14T14:22:10Z

Sources/LaunchDarklySessionReplay/API/ObjcLDMasking.swift

+        view.ldMask()
+    }
+
+    @objc(unmaskView:)


if you are using @objcMembers annotation this is redundant, remove it please

I use for naming as well

mario-launchdarkly · 2025-11-14T14:22:20Z

Sources/LaunchDarklySessionReplay/API/ObjcLDMasking.swift

+        view.ldUnmask()
+    }
+
+    @objc(ignoreView:)


if you are using @objcMembers annotation this is redundant, remove it please

mario-launchdarkly · 2025-11-14T14:24:27Z

Sources/LaunchDarklySessionReplay/ScreenCapture/MaskCollector.swift

-//            let corner1 = CGPoint(x: lBounds.width, y: 0)
-
+        } else {
+           // TODO: finish 3D animations


remove else if you are not implementing/handling this

Sources/LaunchDarklySessionReplay/ScreenCapture/MaskCollector.swift

* main: feat: ignore masking (#80)

🤖 I have created a release *beep* *boop* --- ## [0.10.0](0.9.2...0.10.0) (2025-11-15) ### Features * ignore masking ([#80](#80)) ([1372064](1372064)) * options refactor ([#75](#75)) ([b442cbc](b442cbc)) * refactor instrumentation options ([#77](#77)) ([ebc2e24](ebc2e24)) ### Bug Fixes * touch throttle ([#81](#81)) ([6d1cd15](6d1cd15)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).  --- > [!NOTE] > Bumps SDK to 0.10.0 and updates the changelog with new features and a bug fix. > > - **Release**: bump version to `0.10.0` > - Update `.` version in `.release-please-manifest.json` > - Update `sdkVersion` in `Sources/LaunchDarklyObservability/Version.swift` > - **Docs**: refresh `CHANGELOG.md` with features (ignore masking, options refactor, instrumentation options refactor) and a bug fix (touch throttle) > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 1bf72a3. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup>

abelonogov-ld added 4 commits November 6, 2025 20:47

shouldIgnore property

9fecac4

start

de6b7f0

ldMask

e176e66

Merge branch 'main' into andrey/ignore-masking

d450316

* main: chore: prepare folders for binaryframework (#79) refactor: get sampling config graphql to poso (#78) feat: refactor instrumentation options (#77) feat: options refactor (#75)

abelonogov-ld requested review from a team and mario-launchdarkly as code owners November 13, 2025 16:51

cursor bot reviewed Nov 13, 2025

View reviewed changes

Sources/LaunchDarklySessionReplay/API/SessionReplayModifier.swift Show resolved Hide resolved

Sources/LaunchDarklySessionReplay/ScreenCapture/MaskCollector.swift Show resolved Hide resolved

abelonogov-ld changed the title ~~feat: ignore masking~~ WIP feat: ignore masking Nov 13, 2025

fix unmaskViews and maskViews

da7f775

abelonogov-ld changed the title ~~WIP feat: ignore masking~~ feat: ignore masking Nov 13, 2025

mario-launchdarkly reviewed Nov 13, 2025

View reviewed changes

Sources/LaunchDarklySessionReplay/ScreenCapture/MaskCollector.swift Show resolved Hide resolved

mario-launchdarkly reviewed Nov 13, 2025

View reviewed changes

Addressed feedback

1d4d2f5

abelonogov-ld requested a review from mario-launchdarkly November 14, 2025 00:49

abelonogov-ld enabled auto-merge (squash) November 14, 2025 01:40

abelonogov-ld added 4 commits November 13, 2025 17:40

Merge branch 'main' into andrey/ignore-masking

e8aeb8e

ObjcLDMasking API

0bd899a

Merge branch 'main' into andrey/ignore-masking

50d780c

* main: fix: touch throttle (#81)

Merge branch 'andrey/ignore-masking' of github.com:launchdarkly/swift…

10fadca

…-launchdarkly-observability into andrey/ignore-masking * 'andrey/ignore-masking' of github.com:launchdarkly/swift-launchdarkly-observability:

cursor bot reviewed Nov 14, 2025

View reviewed changes

Sources/LaunchDarklySessionReplay/ScreenCapture/MaskCollector.swift Show resolved Hide resolved

mario-launchdarkly reviewed Nov 14, 2025

View reviewed changes

Sources/LaunchDarklySessionReplay/ScreenCapture/MaskCollector.swift Outdated Show resolved Hide resolved

review feedback

c6c149d

abelonogov-ld requested a review from mario-launchdarkly November 14, 2025 22:26

mario-launchdarkly approved these changes Nov 15, 2025

View reviewed changes

abelonogov-ld merged commit 1372064 into main Nov 15, 2025
5 checks passed

abelonogov-ld deleted the andrey/ignore-masking branch November 15, 2025 00:29

LaunchDarklyReleaseBot mentioned this pull request Nov 14, 2025

chore(main): release 0.10.0 #76

Merged

abelonogov-ld added a commit that referenced this pull request Nov 15, 2025

Merge branch 'main' into andrey/swift-ui-masking-fix

ddb4ae5

* main: feat: ignore masking (#80)



		func shouldIgnore(_ view: UIView) -> Bool {
		let viewType = type(of: view)

feat: ignore masking #80

feat: ignore masking #80

Conversation

abelonogov-ld commented Nov 13, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

abelonogov-ld commented Nov 13, 2025 •

edited by cursor bot

Loading