fix: Handle redis errors during mutations. #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
commented
Nov 10, 2025
Member
Author
There was a problem hiding this comment.
More lenient supervision strategy.
Member
Author
There was a problem hiding this comment.
This one isn't directly part of the initial issue as it applies to the update processor.
kinyoklion
commented
Nov 10, 2025
Member
Author
There was a problem hiding this comment.
Only pre-create buckets when not in daemon mode.
kinyoklion
commented
Nov 10, 2025
Member
Author
There was a problem hiding this comment.
Handle errors from eredis calls. This just logs and doesn't crash the process.
kinyoklion
commented
Nov 10, 2025
Member
Author
There was a problem hiding this comment.
The supervision strategy being updated that is relevant to the original issue.
Member
Author
|
bugbot review |
keelerm84
approved these changes
Nov 10, 2025
kinyoklion
pushed a commit
that referenced
this pull request
Nov 12, 2025
🤖 I have created a release *beep* *boop* --- ## [3.8.1](v3.8.0...v3.8.1) (2025-11-12) ### Bug Fixes * Handle connection errors during read operations. ([#163](#163)) ([5838c2b](5838c2b)) * Handle redis errors during mutations. ([#165](#165)) ([9dbe853](9dbe853)) * Prevent uninitialized SDK warning in daemon mode. ([#162](#162)) ([0961922](0961922)) * Redact SDK in gen_server descriptions and network errors. ([#166](#166)) ([3a4e005](3a4e005)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next PR for #161
When redis wasn't available during application start it would cause the redis process to crash even in daemon mode.
There are a few factors that contributed to this:
This PR makes adjustments to each of these behaviors.
There is some additional logic for ETS which will trigger a reconnection if there was an attempt at a store update during a store outage. We may want to consider something like this for redis as well. It will not affect daemon mode.